Perma-FAIL browser_google_behavior.js time out

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andreio, Assigned: andreio)

Tracking

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Failure https://treeherder.mozilla.org/#/jobs?repo=pine&revision=524b2f921428edc800ec2e33de4d85caf8719911&selectedJob=129664319

This is part of the work necessary to land the prerendering patch for Activity Stream.
Assignee

Updated

2 years ago
Assignee: nobody → andrei.br92
Assignee

Updated

2 years ago
Attachment #8906591 - Flags: review?(edilee)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

https://reviewboard.mozilla.org/r/178336/#review183422

Did you run this test with prerendering (current activity stream master). I seem to be getting these test failures even with the fix here:
```
Browser Chrome Test Summary
	Passed: 6
	Failed: 6
	Todo: 0
	Mode: e10s
*** End BrowserChrome Test Results ***
The following tests failed:
50 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | Check search URL for 'foo' - "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 99
Stack trace:
    chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:99
    Tester_execTest@chrome://mochikit/content/browser-test.js:794:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:694:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
51 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
52 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b-ab" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
53 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b-ab" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
54 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
55 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
```
Attachment #8906591 - Flags: review?(edilee) → review-

Comment 5

2 years ago
To be clear, your test change does make it so that the test doesn't time out, but then uncovers those additional test failures.

Comment 6

2 years ago
Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

Nevermind! Those test failures are probably from bug 1315953. Reviewing again.
Attachment #8906591 - Flags: review- → review?(edilee)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

https://reviewboard.mozilla.org/r/178336/#review183452

Works for me on non-artifact builds! Thanks.
Attachment #8906591 - Flags: review?(edilee) → review+

Comment 8

2 years ago
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/105783286166
Fix Activity Stream related test failure in browser_google_behavior.js. r=Mardak
https://hg.mozilla.org/mozilla-central/rev/105783286166
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

2 years ago
Blocks: 1394533
You need to log in before you can comment on or make changes to this bug.