1398739 - Perma-FAIL browser_google_behavior.js time out

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Andrei Oprea [:andreio]]

Failure https://treeherder.mozilla.org/#/jobs?repo=pine&revision=524b2f921428edc800ec2e33de4d85caf8719911&selectedJob=129664319

This is part of the work necessary to land the prerendering patch for Activity Stream.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

Review commit: https://reviewboard.mozilla.org/r/178336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178336/

Comment 2

[Andrei Oprea [:andreio]]

Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=e37f89b3365f373f4064d1a1411a75c37ad10b63&selectedJob=130079239

Comment 3

[Andrei Oprea [:andreio]]

Fix is similar to https://searchfox.org/mozilla-central/rev/00fa5dacedb925022f53d025121f1a919508e7ce/browser/base/content/test/newtab/head.js#474 should be more flexible this way.

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

https://reviewboard.mozilla.org/r/178336/#review183422

Did you run this test with prerendering (current activity stream master). I seem to be getting these test failures even with the fix here:
```
Browser Chrome Test Summary
	Passed: 6
	Failed: 6
	Todo: 0
	Mode: e10s
*** End BrowserChrome Test Results ***
The following tests failed:
50 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | Check search URL for 'foo' - "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 99
Stack trace:
    chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:99
    Tester_execTest@chrome://mochikit/content/browser-test.js:794:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:694:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
51 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
52 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b-ab" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
53 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b-ab" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
54 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
55 INFO TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_google_behavior.js | "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b" == "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js :: testSearchEngine :: line 180
Stack trace:
chrome://mochitests/content/browser/browser/components/search/test/browser_google_behavior.js:testSearchEngine:180
```

Comment 5

[Ed Lee :Mardak]

To be clear, your test change does make it so that the test doesn't time out, but then uncovers those additional test failures.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

Nevermind! Those test failures are probably from bug 1315953. Reviewing again.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8906591 [details]
Bug 1398739 - Fix Activity Stream related test failure in browser_google_behavior.js.

https://reviewboard.mozilla.org/r/178336/#review183452

Works for me on non-artifact builds! Thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/105783286166
Fix Activity Stream related test failure in browser_google_behavior.js. r=Mardak

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/105783286166