1398762 - "Unparseable host permission" error displayed in the browser console

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P3)

Description

[CosminB]

Attachment: mozextension.gif

[Affected versions]:
- Firefox 57.0a1 (2017-09-10) 

[Affected platforms]:
- Android 6.0.1

[Prerequisites]
- set xpinstall.signatures.dev-root to true
- set xpinstall.signatures.required to false
- set extensions.webapi.testing to true
- set extensions.webextPermissionPrompts to true

[Steps to reproduce]:
1.Tap the toggle button from https://addons-dev.allizom.org/en-US/firefox/addon/testingstorage/ 
2.Look at the browser console.

[Expected results]:
- No error is displayed.

[Actual results]:
- The Unparseable host permission moz-extension://2068d18d-b2ce-4a73-a3fc-cc24ab3cf2f2/*
Extension.jsm:838 error is displayed.

Please see the attached video.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

I've investigated this issue a bit and it seems that it is related to an implicit "moz-extension://" host permission that any extension gets on its own extension URL:

- http://searchfox.org/mozilla-central/rev/00fa5dacedb925022f53d025121f1a919508e7ce/toolkit/components/extensions/Extension.jsm#602-604

Which is then is logged as an error when ExtensionData.formatPermissionStrings helper function checks the extension host permissions:

- http://searchfox.org/mozilla-central/rev/00fa5dacedb925022f53d025121f1a919508e7ce/toolkit/components/extensions/Extension.jsm#836-840

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1398762 Fix unparseable host permission warning

Review commit: https://reviewboard.mozilla.org/r/196886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196886/

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8925739 [details]
Bug 1398762 Fix unparseable host permission warning

https://reviewboard.mozilla.org/r/196886/#review202348

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3fe7b47cdac
Fix unparseable host permission warning r=mixedpuppy

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f3fe7b47cdac

Comment 6

[CosminB]

Attachment: Bug1398762.zip

This issue is verified as fixed on Firefox 58.0a1 (2017-11-08) under Wind 7 64-bit, Mac OS X 10.13 and Android 7.1.2. 

The unparseable host permission warning is not displayed in the browser console.  

Please see the attached video.