1398875 - Fixing test_devtools_serviceworker_interception.html

Status: RESOLVED DUPLICATE of bug 1397365

(Core :: DOM: Service Workers, enhancement)

Description

[Ben Hsu [:HoPang]]

There are some defects in this testcase which is currently blocking bug 1397365.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Should wait for "load" event as well before testing

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ben, thank you for investigating!

Not sure if it's applicable, but in bug 1397365 comment 15, :dao pointed out that whenDelayedStartupFinished should be used instead of onload.
It may also apply here.

Comment 3

[Ben Hsu [:HoPang]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Ben, thank you for investigating!
> 
> Not sure if it's applicable, but in bug 1397365 comment 15, :dao pointed out
> that whenDelayedStartupFinished should be used instead of onload.
> It may also apply here.

You're more than welcome, and thanks for the advice :)

Very interesting, what I am doing is waiting "onload" before actually running testing part, which, to some extent, conflicts with the solution provided by :dao, but I don't actually know what is going on and what should be done here. Let me NI? Andrea as well for more input.

Comment 4

[Ben Hsu [:HoPang]]

Hi Andrea,

It seems that I neglected something important to simplify this testcase when writing it. After comparing this with test_privateBrowsing.html, I found waiting for "onload"[0] in additional to "DOMContentLoaded" is somehow necessary, but I just don't have any clue. Do you mind kindly shedding some light here?

[0] http://searchfox.org/mozilla-central/source/dom/workers/test/serviceworkers/test_privateBrowsing.html#20

Comment 5

[Dão Gottwald [:dao]]

browser-delayed-startup-finished is usually your safest bet, so you should use this unless you have some specific reason to test the new window earlier than that.

Comment 6

[Ben Hsu [:HoPang]]

Since the patch is adopted and reviewed in bug 1397365, I am closing this bug. Thanks everyone for helping.