1398908 - Add automated test that uses nonexistent script from extension JAR file

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P1)

Description

[Haik Aftandilian [:haik]]

In bug 1395898, an extension included an HTML file with a <script> tag referring to a script that was missing from the JAR file. This exposed a bug in the ExtensionProtocolHandler which caused loading the HTML file to hang. We should have a test (or update an existing test) to exercise how missing files in a JAR are handled in ExtensionProtocolHandler remoting code.

Comment 1

[Haik Aftandilian [:haik]]

The test should also add coverage for unpacked extensions that have links to missing scripts.

Comment 2

[Kris Maglione [:kmag]]

This has caused numerous serious issues over the past few months. We should prioritize getting it tested.

Comment 3

[Haik Aftandilian [:haik]]

Attachment: Bug 1398908 - Add automated test that uses nonexistent script from extension JAR file.

Review commit: https://reviewboard.mozilla.org/r/186458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186458/

Comment 4

[Haik Aftandilian [:haik]]

Comment on attachment 8915233 [details]
Bug 1398908 - Add automated test that uses nonexistent script from extension JAR file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186458/diff/1-2/

Comment 5

[Haik Aftandilian [:haik]]

The posted patch adds tests for missing scripts from a WebExtension JAR. Without the ExtensionProtocolHandler fixes for bug 1402205 and bug 1395898, this test results in hangs. We need the same tests for unpacked extensions, but I haven't been able to get the unpacked tests to work and don't have cycles to work more on this right now.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8915233 [details]
Bug 1398908 - Add automated test that uses nonexistent script from extension JAR file.

https://reviewboard.mozilla.org/r/186458/#review195138

This is great, but can you move it to an xpcshell test?  Look for "contentPage" for an example of getting a browser page loaded. r+ with that.

Comment 7

[Haik Aftandilian [:haik]]

Comment on attachment 8915233 [details]
Bug 1398908 - Add automated test that uses nonexistent script from extension JAR file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186458/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/513578be7da2
Add automated test that uses nonexistent script from extension JAR file. r=mixedpuppy

Comment 9

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/7f158a80dea9 for eslint failures, https://treeherder.mozilla.org/logviewer.html#?job_id=137715337&repo=autoland

Comment 10

[Haik Aftandilian [:haik]]

Comment on attachment 8915233 [details]
Bug 1398908 - Add automated test that uses nonexistent script from extension JAR file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186458/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9b621688d28
Add automated test that uses nonexistent script from extension JAR file. r=mixedpuppy

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a9b621688d28

Comment 13

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ or "in-testsuite+" flags.

Comment 14

[Haik Aftandilian [:haik]]

This bug adds a test for existing functionality with no other code changes so I've set in-testsuite+.