1398942 - Make nsPipe3.cpp use diagnostic asserts

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P5)

Description

[Ben Kelly [:bkelly, not reviewing]]

+++ This bug was initially created as a clone of Bug #1397595 +++

Forked from bug 1397595.  We should make nsPipe3.cpp use diagnostic asserts to catch state issues earlier.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Convert existing nsPipe3.cpp MOZ_ASSERT's to use MOZ_DIAGNOSTIC_ASSERT. r=froydnj

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Convert nsPipe3.cpp NS_ASSERTION() calls to hard assertions. r=froydnj

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

NI myself to push this after 57 merges to beta.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

I spoke with Andrew Overholt about this.  It seems like getting the assertions in sooner would be better for overall FF57 stability.  Yes, it might result in short term crashes, but those crashes will likely reflect real problems in the browser we are unaware of right now.  Andrew spoke with Nathan about it and he said he's "happy to be overruled".  So I'm going to go ahead and land this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e69dd626f0
P1 Convert existing nsPipe3.cpp MOZ_ASSERT's to use MOZ_DIAGNOSTIC_ASSERT. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/c777acbcd2a9
P2 Convert nsPipe3.cpp NS_ASSERTION() calls to hard assertions. r=froydnj

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/68e69dd626f0
https://hg.mozilla.org/mozilla-central/rev/c777acbcd2a9