Make nsPipe3.cpp use diagnostic asserts

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P5
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1397595 +++

Forked from bug 1397595.  We should make nsPipe3.cpp use diagnostic asserts to catch state issues earlier.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
NI myself to push this after 57 merges to beta.
Flags: needinfo?(bkelly)
I spoke with Andrew Overholt about this.  It seems like getting the assertions in sooner would be better for overall FF57 stability.  Yes, it might result in short term crashes, but those crashes will likely reflect real problems in the browser we are unaware of right now.  Andrew spoke with Nathan about it and he said he's "happy to be overruled".  So I'm going to go ahead and land this.
Flags: needinfo?(bkelly)

Comment 5

2 years ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e69dd626f0
P1 Convert existing nsPipe3.cpp MOZ_ASSERT's to use MOZ_DIAGNOSTIC_ASSERT. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/c777acbcd2a9
P2 Convert nsPipe3.cpp NS_ASSERTION() calls to hard assertions. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/68e69dd626f0
https://hg.mozilla.org/mozilla-central/rev/c777acbcd2a9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.