1398982 - 129,000 instances of "stylo: ServoStyleSheets don't support <style scoped>" emitted from dom/base/nsStyleLinkElement.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Eric Rahm [:erahm]]

> 129003 WARNING: stylo: ServoStyleSheets don't support <style scoped>: file dom/base/nsStyleLinkElement.cpp, line 434

This warning [1] shows up in the following test suites:

>  24455 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>  12041 - test-linux64/debug-mochitest-e10s-9 9
>   4745 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
>   4470 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>   4469 - test-linux64/debug-reftest-e10s-1 R1
>   3386 - test-linux64/debug-mochitest-e10s-6 6
>   3306 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
>   3288 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>   3282 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
>   3239 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>   3229 - test-linux64/debug-reftest-e10s-2 R2
>   2887 - test-linux64/debug-reftest-e10s-5 R5
>   2885 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>   2660 - test-linux64/debug-reftest-stylo-e10s-1 Rs1
>   2410 - test-linux64/debug-reftest-e10s-6 R6
>   2408 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>   2374 - test-linux64/debug-reftest-stylo-e10s-2 Rs2
>   2336 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>   2302 - test-linux64/debug-reftest-e10s-4 R4
>   2300 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>   1767 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>   1765 - test-linux64/debug-reftest-e10s-3 R3
>   1762 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>   1760 - test-linux64/debug-reftest-e10s-8 R8
>   1724 - test-linux64/debug-reftest-stylo-e10s-6 Rs6
>   1692 - test-linux64/debug-reftest-stylo-e10s-5 Rs5
>   1481 - test-linux64/debug-reftest-stylo-e10s-4 Rs4
>   1279 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>   1219 - test-linux64/debug-crashtest-e10s C
>   1162 - test-linux64/debug-mochitest-e10s-2 2
>   1160 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>   1135 - test-linux64/debug-reftest-stylo-e10s-3 Rs3
>   1125 - test-linux64/debug-mochitest-e10s-3 3
>   1032 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
>   1013 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>   1013 - test-linux64/debug-reftest-stylo-e10s-8 Rs8
>    937 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>    889 - test-linux64/debug-reftest-e10s-7 R7
>    888 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>    888 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>    819 - test-linux64/debug-mochitest-e10s-8 8
>    741 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>    578 - test-linux64/debug-reftest-stylo-e10s-7 Rs7
>    544 - test-linux64/debug-mochitest-e10s-5 5
>    526 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>    449 - test-linux64/debug-mochitest-e10s-7 7
>    424 - test-linux64/debug-mochitest-chrome-1 c1
>    382 - test-linux64/debug-mochitest-e10s-10 10
>    313 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>    283 - test-linux64/debug-mochitest-e10s-4 4
>    280 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>    279 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>    272 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>    264 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>    248 - test-linux64/debug-test-verify-e10s TV
>    237 - test-linux64/debug-mochitest-a11y a11y
>    229 - test-linux64/debug-mochitest-media-e10s-3 mda3
>    228 - test-linux64/debug-mochitest-media-e10s-2 mda2
>    227 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>    223 - test-linux64/debug-mochitest-media-e10s-1 mda1
>    216 - test-linux64/debug-mochitest-chrome-3 c3
>    198 - test-linux64/debug-mochitest-e10s-1 1
>    193 - test-linux64/debug-marionette-headless-e10s MnH
>    191 - test-linux64/debug-mochitest-clipboard-e10s cl
>    190 - test-linux64/debug-marionette-e10s Mn
>    188 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>    187 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>    163 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>    153 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>    149 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>    134 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>    134 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>    128 - test-linux64/debug-mochitest-chrome-2 c2
>    103 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>    100 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>     94 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>     91 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     71 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>     63 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>     59 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     52 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>     51 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     51 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>     45 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     45 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>     42 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     37 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     33 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     26 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     24 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     24 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>     22 - test-linux64/debug-mochitest-gpu-e10s gpu
>     20 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>      4 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      4 - test-linux64/debug-web-platform-tests-wdspec-e10s Wd
>      4 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>      2 - test-linux64/debug-jsreftest-e10s-2 J2
>      1 - test-linux64/debug-jsreftest-e10s-3 J3
>      1 - test-linux64/debug-jsreftest-e10s-1 J1
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13

It shows up in 8862 tests. A few of the most prevalent:

>  14089 - [e10s] /quirks-mode/hashless-hex-color.html
>   9532 - [e10s] /quirks-mode/unitless-length.html
>   2586 - [e10s] layout/style/test/test_logical_properties.html
>   2201 - [e10s] Shutdown
>   1898 - [e10s] layout/style/test/test_selectors.html
>   1678 - [e10s] layout/style/test/test_media_queries.html
>    880 - [e10s] layout/style/test/test_parser_diagnostics_unprintables.html
>    822 - [e10s] layout/style/test/test_first_letter_restrictions.html
>    801 - [e10s] layout/style/test/test_placeholder_restrictions.html
>    801 - [e10s] layout/style/test/test_first_line_restrictions.html

[1] https://hg.mozilla.org/mozilla-central/annotate/f9a5e9ed6210/dom/base/nsStyleLinkElement.cpp#l434

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We are not using P4 for bug triage, moving to P3 (backlog).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b21f5d72f54
Remove style scoped warnings for stylo. r=me

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This caused a number of unexpected passes in reftests: https://treeherder.mozilla.org/logviewer.html#?job_id=131362300&repo=autoland

Backed out in https://hg.mozilla.org/integration/autoland/rev/bd58d86f008b9f3fa415bac712443ffb3282065d

Comment 4

[Eric Rahm [:erahm]]

(In reply to Wes Kocher (:KWierso) from comment #3)
> This caused a number of unexpected passes in reftests:
> https://treeherder.mozilla.org/logviewer.html#?job_id=131362300&repo=autoland
> 
> Backed out in
> https://hg.mozilla.org/integration/autoland/rev/
> bd58d86f008b9f3fa415bac712443ffb3282065d

Presumably we should keep the `NS_ERROR`.

Comment 5

[Bobby Holley (:bholley)]

(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #4)
> (In reply to Wes Kocher (:KWierso) from comment #3)
> > This caused a number of unexpected passes in reftests:
> > https://treeherder.mozilla.org/logviewer.html#?job_id=131362300&repo=autoland
> > 
> > Backed out in
> > https://hg.mozilla.org/integration/autoland/rev/
> > bd58d86f008b9f3fa415bac712443ffb3282065d
> 
> Presumably we should keep the `NS_ERROR`.

Yeah, you're right.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8ab95c5a34b
Remove style scoped warnings for stylo. r=me

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c8ab95c5a34b