1398988 - Add Option+Cmd+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Chris Peterson [:cpeterson]]

We should add Option+Cmd+U as an alternate keyboard shortcut for "View Source" on macOS so Safari and Chrome web developers don't need to retrain their muscle memory.

Chrome and IE/Edge on Windows: Ctrl+U
Firefox on Windows: Ctrl+U

Safari and Chrome on macOS: Option+Cmd+U
Firefox on macOS: Cmd+U

This keyboard shortcut alias was a feature request from Twitter:

https://twitter.com/justnorris/status/905377487722565632

Below are links to lists of Chrome's keyboard shortcuts. There are other keyboard shortcuts that differ between Firefox, Chrome, and Safari.

https://support.google.com/chrome/answer/157179?hl=en

https://developers.google.com/web/tools/chrome-devtools/shortcuts

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1398988 - Add Option+Command+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome.

Review commit: https://reviewboard.mozilla.org/r/178610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178610/

Comment 2

[Chris Peterson [:cpeterson]]

Joe and Markus, I'm not sure who the appropriate reviewer should be. The keyboard shortcut for "View Source" falls into a limbo between DevTools, Mac widget, and UX. <:)

Comment 3

[Markus Stange [:mstange]]

I'd put the responsibility with browser frontend people.
As for this change, you have my approval from the Mac widget side, but I don't think my side is very relevant.

Comment 4

[Markus Stange [:mstange]]

Gijs, can you suggest an appropriate reviewer?

Comment 5

[:Gijs (he/him)]

Comment on attachment 8906877 [details]
Bug 1398988 - Add Option+Command+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome.

https://reviewboard.mozilla.org/r/178610/#review183718

I think I can review this, given how old/browser-y view source is and the location of the code change. I'm sure Joe will yell at me if he disagrees. :-)

This is effectively an r+ for making this change. However, we really need to use a separate key l10n string. There should probably also be a localization comment next to the string pointing to this bug and explaining why we have a second string (ie safari/chrome parity), so that other locales can, uh, actually do the same thing as French/Chinese/Canadian Safari/Chrome localizations (whatever that is - I'm not actually sure!). I'm erring on the side of clearing review rather than r+ mostly because it's so annoying to re-request review with mozreview if you wanted to do that. I promise a speedy r+ for an updated version that addresses the comments.

::: browser/base/content/browser-sets.inc:290
(Diff revision 1)
>      <key key="&reloadCmd.commandkey;" command="Browser:Reload" modifiers="accel" id="key_reload"/>
>      <key key="&reloadCmd.commandkey;" command="Browser:ReloadSkipCache" modifiers="accel,shift"/>
>      <key id="key_viewSource" key="&pageSourceCmd.commandkey;" command="View:PageSource" modifiers="accel"/>
> +#ifdef XP_MACOSX
> +    <!-- Also support Option+Cmd+U as alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome. -->
> +    <key id="key_viewSource2" key="&pageSourceCmd.commandkey;" command="View:PageSource" modifiers="accel,alt"/>

Please duplicate the key l10n id, probably naming it something like "pageSourceCmd.macCommandKey" (based on the others in that style), and use that. We can't assume that locales other than English can reuse the same key for both the cmd-<foo> and cmd-alt-<foo> switch.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to :Gijs from comment #5)
> Please duplicate the key l10n id, probably naming it something like
> "pageSourceCmd.macCommandKey" (based on the others in that style), and use
> that. We can't assume that locales other than English can reuse the same key
> for both the cmd-<foo> and cmd-alt-<foo> switch.

Thanks, Gijs! I forgot that other locales might use different letters for their keyboard shortcuts. I added a localization comment and changed the `key_viewSource2` name to the more descriptive `key_viewSourceSafari`. This new patch is much nicer. :)

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 8906877 [details]
Bug 1398988 - Add Option+Command+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178610/diff/1-2/

Comment 8

[:Gijs (he/him)]

Comment on attachment 8906877 [details]
Bug 1398988 - Add Option+Command+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome.

https://reviewboard.mozilla.org/r/178610/#review184250

LGTM, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b15b56420ad
Add Option+Command+U as an alternate keyboard shortcut for "View Source" on macOS like Safari and Chrome. r=Gijs

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b15b56420ad