1399036 - Enable date/time input by default on all builds

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement)

Description

[Jessica Jong [:jessica] (inactive)]

We plan to ship this in Firefox v57.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Oh YES!

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: patch.

We got the pre-beta signoff report with green light from QA, yay!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8907636 [details] [diff] [review]
patch.

Review of attachment 8907636 [details] [diff] [review]:
-----------------------------------------------------------------

\o/!! Great job, everyone!

Comment 4

[Jessica Jong [:jessica] (inactive)]

Thanks everyone! :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de8606af7e6951915df896c839d56eb545b30e2a&group_state=expanded

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2769237547ba
Enable date/time input by default on all builds. r=mconley

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2769237547ba

Comment 7

[Chris Mills [:cmills]]

I have documented this; the browser compat data has been updated on relevant pages:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time#Browser_compatibility

I have also removed date/time from the MDN experimental features page, and added a note to the Fx57 rel notes page:

https://developer.mozilla.org/en-US/Firefox/Releases/57#HTML

Comment 8

[Jessica Jong [:jessica] (inactive)]

Thanks for updating the pages!

Comment 9

[Parthiv Shah]

Hi Jessica,
Here are my observations about this feature:
1. In case of partially filled date, validity state's badInput is not getting set to true.
2. when clear button is clicked and user clicks outside, in that case blur event of input control is not getting fired. 
I will report these bugs. I know this feature is in development stage.

Comment 10

[Jessica Jong [:jessica] (inactive)]

(In reply to Parthiv Shah from comment #9)
> Hi Jessica,
> Here are my observations about this feature:
> 1. In case of partially filled date, validity state's badInput is not
> getting set to true.
> 2. when clear button is clicked and user clicks outside, in that case blur
> event of input control is not getting fired. 
> I will report these bugs. I know this feature is in development stage.

Thanks for reporting these issues.
For 1, validity state can only be verified when a valid date/time is set in .value, if date is not complete, we can't verify its validity.
For 2, I could not reproduce it on Nightly macOS.

But, please, do file separate bugs for better tracking. Thanks again.

Comment 11

[Parthiv Shah]

Hi Jessica,
Thank you for your reply. 
For 1, in webkit (chrome) validity state's badInput is set to true in case of partially filled date. Is there any way in Firefox to distinguish between partially filled date and empty date as my validation relies on this.
For 2, Did you fill the date and clear the date using X button? I am able reproduce it on Firefox 57 (64 bit) and Developer Edition 58.0b7 (64-bit).

I have filed separate bugs (Bug 1421555 and Bug 1421558) for better tracking. I have attached demo files so that you can test it and let me know if it is reproducible or not.

Thanks Again Jessica.