1399052 - Dismissing a Pocket recommendation wrongly dismisses the Highlights card of the same page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: dismissing a top story will dismiss a highlight of the same page.gif

[Affected versions]:
- Firefox 57.0a1 Build ID 20170912013600

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- "browser.newtabpage.activity-stream.enabled" and "browser.newtabpage.activity-stream.feeds.section.topstories" are set to true in about:config on a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a New Tab.
2. Navigate to the three Top Stories from Pocket.
3. Open a new tab and dismiss one of the Top Stories.
4. Observe the Top Stories and Highlights sections. 

[Expected results]:
- The Top Story is dismissed from its section, another one takes it place and there is no change in the Highlights section.

[Actual results]:
- The Top Story is dismissed from its section, but the Highlight card of the same page is also dismissed.

[Notes]:
- Dismissing a Highlight will not dismiss a Top Story of the same page.
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3538 to be uplifted via bug 1401683.

Comment 2

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Managed to reproduce the initial issue on 57.0a1 (2017-09-18). I can confirm the bug is verified fixed on 57.0b6 build1 (20171005195903), using Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6.