Closed Bug 1399055 Opened 5 years ago Closed 5 years ago

Make cross-channel localization ready for Fluent

Categories

(Developer Services :: General, task)

Product:
Developer Services
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stas, Assigned: stas)

References

Details

Attachments

(1 file)

Bug 1399055 - Support Fluent in cross-channel localization.
59 bytes, text/x-review-board-request
Pike
: review+
Details 
The initial iteration of the merge algorithm (bug 1384570) intentionally omits Fluent (.ftl) localization files. We need some changes to compare-locales before we can use the same algorithm to merge legacy and Fluent files.
Depends on: 1399057
Depends on: 1399059
Depends on: 1384570
We can't land this before bug 1384570 and bug 1399057 are fixed, but I'd like to start the review process now since it's really just tests. Which is nice; bug 1399059 paid off :)
Comment on attachment 8915930 [details]
Bug 1399055 - Support Fluent in cross-channel localization.

https://reviewboard.mozilla.org/r/187192/#review192254

r=me with a comment on the details for pre_comment being None.

::: compare_locales/parser.py:590
(Diff revision 1)
>              self.val_span = (entry.value.span.start, entry.value.span.end)
>          else:
>              self.val_span = (0, 0)
>  
>          self.entry = entry
> +        self.pre_comment = None

This one tripped me off, might be good to explain either here and/or the commit message. I *think* I see why it's here and never set, but it'd be good to be explicit.
Attachment #8915930 - Flags: review?(l10n) → review+
Assignee: nobody → stas
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.