1399055 - Make cross-channel localization ready for Fluent

Status: RESOLVED FIXED

(Developer Services :: General, task)

Description

[Staś Małolepszy :stas]

The initial iteration of the merge algorithm (bug 1384570) intentionally omits Fluent (.ftl) localization files. We need some changes to compare-locales before we can use the same algorithm to merge legacy and Fluent files.

Comment 1

[Staś Małolepszy :stas]

Attachment: Bug 1399055 - Support Fluent in cross-channel localization.

Review commit: https://reviewboard.mozilla.org/r/187192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187192/

Comment 2

[Staś Małolepszy :stas]

We can't land this before bug 1384570 and bug 1399057 are fixed, but I'd like to start the review process now since it's really just tests. Which is nice; bug 1399059 paid off :)

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8915930 [details]
Bug 1399055 - Support Fluent in cross-channel localization.

https://reviewboard.mozilla.org/r/187192/#review192254

r=me with a comment on the details for pre_comment being None.

::: compare_locales/parser.py:590
(Diff revision 1)
>              self.val_span = (entry.value.span.start, entry.value.span.end)
>          else:
>              self.val_span = (0, 0)
>  
>          self.entry = entry
> +        self.pre_comment = None

This one tripped me off, might be good to explain either here and/or the commit message. I *think* I see why it's here and never set, but it'd be good to be explicit.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 8915930 [details]
Bug 1399055 - Support Fluent in cross-channel localization.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187192/diff/1-2/

Comment 5

[Staś Małolepszy :stas]

https://hg.mozilla.org/l10n/compare-locales/rev/a9adf495b5e91e1d540ba65d0436b2d59513ad2e
Bug 1399055 - Support Fluent in cross-channel localization. r=Pike