Closed Bug 1399060 Opened 7 years ago Closed 7 years ago

MIPS[64]: Fix simulator build failures

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: miran.karic, Assigned: miran.karic)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36

Steps to reproduce:

MIPS simulator build started failing recently. Also a recent change caused build failure in MIPS64. This fixes both problems.
Attachment #8906998 - Flags: review?(bbouvier)
Attachment #8906998 - Flags: checkin+
Comment on attachment 8906998 [details] [diff] [review]
0001-Bug-1399060-MIPS-64-Fix-simulator-build-failures-r-b.patch

Review of attachment 8906998 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks.

I don't think the "checkin" flag is what you want here. If you set it so as the patch to get checked in, first it must have r+; then one must put "checkin-needed" in the whiteboard. (checkin+ is used to indicate which patches have already been checked in in the past)
Attachment #8906998 - Flags: review?(bbouvier)
Attachment #8906998 - Flags: review+
Attachment #8906998 - Flags: checkin+
Assignee: nobody → miran.karic
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c439271f94d7
MIPS[64]: Fix simulator build failures. r=bbouvier
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c439271f94d7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to Benjamin Bouvier [:bbouvier] from comment #2)
> Comment on attachment 8906998 [details] [diff] [review]
> 0001-Bug-1399060-MIPS-64-Fix-simulator-build-failures-r-b.patch
> 
> Review of attachment 8906998 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me, thanks.
> 
> I don't think the "checkin" flag is what you want here. If you set it so as
> the patch to get checked in, first it must have r+; then one must put
> "checkin-needed" in the whiteboard. (checkin+ is used to indicate which
> patches have already been checked in in the past)

Thank you. When uploading an attachment floating help message under checkin flag says to use it when "you do not have VCS access and wish to request that someone check in your patch". It also says "Users with VCS access can also use this flag to mark which patches they have checked in". That is why I used it but if you think it is not needed and not used in practice then I won't.
You need to log in before you can comment on or make changes to this bug.