Closed
Bug 1399083
Opened 8 years ago
Closed 8 years ago
Consider long term usage of SwiftRouter.
Categories
(Firefox for iOS :: Browser, enhancement, P3)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: jhugman, Assigned: farhan)
Details
(Whiteboard: [MobileCore])
Attachments
(2 files)
Following investigation of Bug 1397799, we'ved found SwiftRouter has some serious flaws.
This includes force-dereferencing and fatalErrors.
This bug tracks a PR submitted to the upstream project. This either needs to be landed or we need to consider a more permanent fork.
https://github.com/skyline75489/SwiftRouter/pull/8
https://bugzilla.mozilla.org/show_bug.cgi?id=1397799
|
Reporter | |
Comment 1•8 years ago
|
||
|
||
Updated•8 years ago
|
Whiteboard: [MobileCore]
|
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → jhugman
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8942638 -
Flags: review?(jhugman)
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8942638 [details] [review]
Pull Request
Comments in the PR.
Attachment #8942638 -
Flags: review?(jhugman) → feedback+
|
|
Reporter | |
Updated•8 years ago
|
Assignee: jhugman → fpatel
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8942638 -
Flags: review?(jhugman)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8942638 -
Flags: review?(jhugman) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
merged master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•