1399092 - Manually disabled legacy add-on is not updated to a webextension version during browser upgrade

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: disabledadd-on.gif

[Affected versions]:
Firefox 57.0a1 (20170912013600)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1.Launch Firefox Release with a clean profile.
2.Install the following legacy add-on: https://addons.mozilla.org/firefox/downloads/file/672156/ublock_origin-1.13.4-an+fx+sm+tb.xpi?src=version-history
3.Navigate to Add-ons Manager -> Extensions and disable the add-on.
4.Close the browser and open the same profile using Firefox 57.


 [Expected Results]:
Legacy add-on is updated to the last available webextension version during the browser upgrade and its status is maintained as disabled.

[Actual Results]:
- The add-on is not updated and it appears as disabled in Legacy Extensions tab.
- The legacy add-on is updated only after a manually check for updates.
- See attached screencast.

Comment 1

[Andrew Swan [:aswan]]

The startup check acts the same as the background update check, it just happens during startup.  Since background update checks don't update disabled extensions, I don't think the startup check should either.

Comment 2

[Vasilica Tamas, QA [:vtamas]]

Attachment: disabled-background-update.gif

(In reply to Andrew Swan [:aswan] from comment #1)
> Since background update checks don't update disabled extensions

I think I will contradict you... because a disabled extension is successfully updated via background method. See attached screencast.

Comment 3

[Andrew Swan [:aswan]]

Whoops, of course you're right.  But still, the startup check is about maintaining consistency with extensions that were running at the end of the previous session.  Since any disabled extensions weren't running at shutdown, I don't think that blocking the subsequent startup on updating them would be wise.