Open Bug 1399138 Opened 2 years ago Updated 2 years ago

Dimensions ­-PaddingSpacingMargins doesn't match the specifications (Compact mode)

Categories

(Firefox :: Theme, defect, P5)

57 Branch
Unspecified
Windows
defect

Tracking

()

Tracking Status
firefox57 --- wontfix

People

(Reporter: valentina.ona, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(7 files)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID:  20170910220126

[Affected versions]:  Nightly 57.0a1

[Affected platforms]:  Windows 8.1 x64

[Steps to reproduce]:
1.Launch Nightly 57.0a1 with a new profile.
2.Go to Customization menu
3.Select Compact from the Density.

[Expected result]:
The dimensions should match the specifications.

[Actual result]:
The dimensions doesn't match as specifications.
Please verify the attachment and what is not correct is marked with yellow.
Priority: -- → P3
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Priority: P3 → P4
I verify this issue on Windows 10 x64 and it's also reproducible.
For Compact mode, on Windows 10, the distance between buttons from URL bar is 4px instead of 2px.

Also, on Windows 10, for the identity block, few dimensions do not respect the Photon specs - please see attachment(Windows10_CompactDensity_IdentityBlockDimensions.jpg)
Duplicate of this bug: 1399821
Also, on Ubuntu 16.04, some distances between buttons do not respect the Photon specs - please see attachment
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
Depends on: 1398103
I think bug 1398103 fixed this, or most of it. Valentina or Brindusa or Roxana, could you please check with the latest nightly?
Flags: needinfo?(valentina.ona)
Flags: needinfo?(roxana.leitan)
Flags: needinfo?(brindusa.tot)
I verified this issue using Nightly 58.0a1 with Build ID 20171102222620 on Windows 10 x64, Windows 7 x32, Windows 8.1 and Ubuntu 16.04 but the issue is not resolved.
Please see the attachment.
Flags: needinfo?(valentina.ona) → needinfo?(dao+bmo)
Flags: needinfo?(roxana.leitan)
Flags: needinfo?(brindusa.tot)
Flags: needinfo?(dao+bmo)
Assignee: nobody → dharvey
The margin+padding around the spacer is wrong in compact mode here, I figured css vars were cleaner than adding :root:not([uidensity=compact]) before every selector that gave this extra margin but happy to switch
Attached image Strange margin
The space between the (i) and the connection icon is behaving strangely for me, it is given a 4px margin (https://searchfox.org/mozilla-central/source/browser/themes/shared/identity-block/identity-block.inc.css#79) however on screen its measuring at 7px, if I reduce that to 0 then the icons actually overlap, incrementally it looks like the margin is doubling but its not a dpi issue and looks extreme for a rendering glitch
actually relooking at ^, it looks like tracking protection icon is interfering and having an effect on layout when its not actually displayed
Changing priority so it orders correctly since its assigned
Priority: P4 → P1
(In reply to Dale Harvey (:daleharvey) from comment #11)
> actually relooking at ^, it looks like tracking protection icon is
> interfering and having an effect on layout when its not actually displayed

The icon is hidden using a negative margin so that it can slide into view when needed: https://searchfox.org/mozilla-central/rev/c8e791091973825680bbba807fc1c4f5bda0f5a1/browser/themes/shared/identity-block/identity-block.inc.css#167-177

(In reply to Dale Harvey (:daleharvey) from comment #9)
> The margin+padding around the spacer is wrong in compact mode here

TBH I'm not sure that adjusting this for compact mode is worthwhile.
Comment on attachment 8930908 [details]
Bug 1399138 - Fix identity block spacing in compact mode.

https://reviewboard.mozilla.org/r/202020/#review213796
Attachment #8930908 - Flags: review?(dao+bmo)
Unassigning for parental leave
Assignee: dharvey → nobody
Priority: P1 → P5
You need to log in before you can comment on or make changes to this bug.