1399176 - Make browserSettings an optional permission

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Bob Silverberg [:bsilverberg]]

As discussed in bug 1322308, browserSettings would be convenient to have as an optional permission, as opposed to a required permission. This bug is to implement that change.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1399176 - Make browserSettings an optional permission,

Review commit: https://reviewboard.mozilla.org/r/178834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178834/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8907145 [details]
Bug 1399176 - Make browserSettings an optional permission,

https://reviewboard.mozilla.org/r/178834/#review183874

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/777f90a6648b
Make browserSettings an optional permission, r=mixedpuppy

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/777f90a6648b

Comment 5

[Will Bamberg [:wbamberg]]

I think this is only a matter of adding it here, yes?
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/optional_permissions

(I mean, it should still be listed in https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions.)

Comment 6

[Bob Silverberg [:bsilverberg]]

Looks good Will. Should browserSettings also be added to the compatibility tables for both of those pages?

Comment 7

[Will Bamberg [:wbamberg]]

Thanks Bob.

I don't add API permissions to the compat tables, because it seems redundant: if a browser supports a permission-protected API, it will support the permission. If it doesn't it won't. Does that sound reasonable? I could add a note to that effect in the browser compat section, just in case anyone's wondering.

Comment 8

[marius.santa]

I can reproduce this issue on Firefox 56.0.2 (20171024165158) under Wind 10 64-bit. 

This issue is verified as fixed on Firefox 57.0b14 (20171102181127), Firefox 58.0a1 (20171102100041) under Wind 10 64-bit and Mac OS X 10.13.

Comment 9

[juraj.masiar]

Update for MDN compatibility table needs merging:
https://github.com/mdn/browser-compat-data/pull/2407
(if somebody has time and permissions)

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/optional_permissions#Browser_compatibility