Closed Bug 1399244 Opened 7 years ago Closed 7 years ago

Implement method for user to assign a site as a Top-Site

Categories

(Firefox for iOS :: Menu and Toolbar, enhancement, P2)

Other
iOS
enhancement

Tracking

()

VERIFIED FIXED
Tracking Status
fxios 10.0 ---
fxios-v10.0 --- verified
fxios-v11.0 --- verified

People

(Reporter: bbell, Unassigned)

References

Details

(Whiteboard: [MobileCore][Photon])

Attachments

(2 files)

575.83 KB, image/png
Details
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
Attached image Pin to Top Sites.png
Users should be able to Pin a site to Top-Sites, and it would be a shame to launch a product that user had no control over. Until a more direct UI surface is available a user should be able to navigate to a page and from the Page Action Menu select "Pin to Top Sites".

This will turn that page into a pinned topsite. 

If more that 16 sites have been pinned the menu will need to be disabled.
> If more that 16 sites have been pinned the menu will need to be disabled.

Ignore this bit. Just trying to think how we can avoid running out of slots. If the user can make over 16 pinned top-sites, that would be ideal.
Blocks: photonios
Priority: -- → P2
Whiteboard: [MobileCore]
Whiteboard: [MobileCore] → [MobileCore][Photon]
If nobody has started this task I can take a shot at fixing this.
Attached file Pull request
Attachment #8914014 - Flags: review?(jhugman)
Updated PR to only include “Pin to top” functionality and not the “remove pin”.
XCUITest added.
Attachment #8914014 - Flags: review?(jhugman) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][Photon] → [MobileCore][Photon][needsuplift]
Whiteboard: [MobileCore][Photon][needsuplift] → [MobileCore][Photon]
Verifying as fix on master 9f46cedf718d5c and 10.0(7233).

Successfully managed to add and remove 16 pins to Top Sites and removed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: