Closed
Bug 1399384
Opened 7 years ago
Closed 7 years ago
(photon) follow up of visual refinements
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, enhancement)
Firefox for Android Graveyard
Theme and Visual Design
Unspecified
Android
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jwu, Assigned: jwu)
References
Details
(Whiteboard: [FNC][SPT57.3][INT])
Attachments
(3 files)
There are two refinements requirement mentioned by designer and I would like to fix them in this bug: 1. Change the URL placeholder text color from #737373 to #B2B2B2; 2. Change the status bar color based on different situation: - For mobile, the status bar color is #F7FAFC in normal mode, #38383D in private mode, and #272727 in tabs tray page - For tablet, the status bar color is always #272727
Assignee | ||
Comment 1•7 years ago
|
||
One more change we would like to apply here is to adjust the padding of edit layout in toolbar, also to support RTL properly, we'll move the padding setting(paddingRight/paddingEnd) from layout to different version styles.xml
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8907482 [details] Bug 1399384 - Part 1: Change placeholder text color from #737373 to #B2B2B2. https://reviewboard.mozilla.org/r/179176/#review184284
Attachment #8907482 -
Flags: review?(cnevinchen) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8907483 [details] Bug 1399384 - Part 2: Status bar color refinements. https://reviewboard.mozilla.org/r/179178/#review184288
Attachment #8907483 -
Flags: review?(cnevinchen) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8907484 [details] Bug 1399384 - Part 3: Adjust edit layout padding and move values from layout to different styles.xml. https://reviewboard.mozilla.org/r/179180/#review184292 ::: commit-message-7b150:2 (Diff revision 1) > +Bug 1399384 - Part 3: Adjust edit layout padding and move values from layout to different styles.xml. r?nechen > + Maybe add a comment about why we need this setup for RTL problem
Attachment #8907484 -
Flags: review?(cnevinchen) → review+
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8907484 [details] Bug 1399384 - Part 3: Adjust edit layout padding and move values from layout to different styles.xml. https://reviewboard.mozilla.org/r/179180/#review184292 > Maybe add a comment about why we need this setup for RTL problem The idea is came from the comment[1] in bug 1350661. Bug 1350661 - Extract layout attributes into styles in order to separate api 15 and 17 style tree, r=sebastian __Device_Configuration__|__o_Applied_Style_______________ ldrtl-v17 v17 v15 | o o o | UrlBar.Entry \ | | | -----o | | UrlBar.V17.Entry(start/end) \ | | \ o | UrlBar.V15.Entry(left/right) \ | | --o | UrlBar.Base.Entry(original style) Though Android support RTL since API level 17(JB_MR1), it's really buggy at that moment. This patch fix a severe UI layout attribute bug, which only happen on android 4.2 in RTL language context: If view attributes "start/end" and "left/right" are both written in a view layout xml, they will both be applied and cause UI abnormal. In API 18 and above, "left" will be ignored if "start" also exist. For example, as below show, alignLeft and alignStart are both exist in ImageView. On android 4.2 with RTL context, it's width will both align Left and Start(Right), cause the symptom that ImageView have the same width and cover on the view "back." ``` <ImageView android:id="@+id/url_bar_entry" android:layout_alignLeft="@+id/back" android:layout_alignStart="@+id/back" ``` [1] https://hg.mozilla.org/mozilla-central/rev/f421e4a9970c
Pushed by topwu.tw@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1fb3bbbaa565 Part 1: Change placeholder text color from #737373 to #B2B2B2. r=nechen https://hg.mozilla.org/integration/autoland/rev/ccc012158063 Part 2: Status bar color refinements. r=nechen https://hg.mozilla.org/integration/autoland/rev/33964845834c Part 3: Adjust edit layout padding and move values from layout to different styles.xml. r=nechen
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1fb3bbbaa565 https://hg.mozilla.org/mozilla-central/rev/ccc012158063 https://hg.mozilla.org/mozilla-central/rev/33964845834c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Whiteboard: [FNC][SPT57.3][INT]
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•