1399449 - Convert responsivedesign.jsm to a module

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, enhancement)

Description

[Alexandre Poirot [:ochameau]]

http://searchfox.org/mozilla-central/source/devtools/client/responsivedesign/responsivedesign.jsm
Should be a commonjs modudle instead of a JSM.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1399449 - Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module.

Review commit: https://reviewboard.mozilla.org/r/179308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179308/

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5dbc35170ce89383a98fe2afcaddbc8851768fa

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8907626 [details]
Bug 1399449 - Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module.

https://reviewboard.mozilla.org/r/179308/#review184466

Looks great, thanks for doing this!

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8907626 [details]
Bug 1399449 - Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179308/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6263822a90f
Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module. r=jryans

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a6263822a90f