Closed
Bug 1399523
Opened 7 years ago
Closed 7 years ago
Stop calling compare-locales from mozharness, now that the build does so
Categories
(Release Engineering :: Applications: MozharnessCore, enhancement)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(2 files)
With bug 1385227, the build system now always runs compare-locales in the way that it wants it. We should drop calling it from mozharness before that. Callek, do you agree or do you see any weirdness that would prevent us from doing this?
Flags: needinfo?(bugspam.Callek)
Comment 1•7 years ago
|
||
I think we should do this, but I'd like to confirm that BB-based release l10n runs the repacks in a way that *actually* does the compare-locales (without explicit mozharness invocation) before landing a patch for this. Of course once all l10n is in tree this becomes even easier ;-)
Flags: needinfo?(bugspam.Callek)
Assignee | ||
Comment 2•7 years ago
|
||
I dove into the build logs for the 57 devedition b1 builds, and they're using the in-build compare-locales and merge dirs.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Justin, I'd still need to do all the config jazz after this, but I figured I'd get feedback on this first. Also, feel free to denote a different reviewer.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → l10n
Assignee | ||
Comment 5•7 years ago
|
||
Pushed this to try via https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e7f1f3092557a61a626b80253ffeaae5775ec9c, just to get a feel for it.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Added the configs, too, as the try build was failing on that. https://treeherder.mozilla.org/#/jobs?repo=try&revision=366b8806e257c016334753eba512a02d34dd566d is now successfully through Android, linux, and macos. I didn't do windows as that'd require me to aquire the config hacks again, which, well, I didn't want to ;-)
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8908667 [details] bug 1399523, now that we run l10n-merge in-build, drop it from mozharness, https://reviewboard.mozilla.org/r/180296/#review186074 ::: testing/mozharness/mozharness/mozilla/l10n/locales.py (Diff revision 2) > return locales > > - def run_compare_locales(self, locale, halt_on_failure=False): > - dirs = self.query_abs_dirs() > - env = self.query_l10n_env() > - compare_locales_error_list = list(PythonErrorList) nit: can remove the PythonErrorList import above.
Attachment #8908667 -
Flags: review?(bugspam.Callek) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8909288 [details] bug 1399523, adjust configs to not merge l10n in mozharness, https://reviewboard.mozilla.org/r/180872/#review186076 I didn't double check that all cases of these config vars and env vars are gone, but the eyeball on number of occurrances looks right.
Attachment #8909288 -
Flags: review?(bugspam.Callek) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=43d1d3e1c1cb landed on autoland. Re the config patches, I did those with find and grep on files, I should've found all occurences. (Learned from last time to not just find .py files)
Comment 14•7 years ago
|
||
Pushed by axel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67a43ebd7bbd now that we run l10n-merge in-build, drop it from mozharness, r=Callek
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67a43ebd7bbd https://hg.mozilla.org/mozilla-central/rev/43d1d3e1c1cb
You need to log in
before you can comment on or make changes to this bug.
Description
•