Closed Bug 1399651 Opened 7 years ago Closed 7 years ago

Pocket'ing a page in popup window causes half of the library icon to be shown on the top left corner

Categories

(Firefox :: Theme, defect, P1)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: StefanG_QA, Assigned: jaws)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0  (20170913100125)

STR:
 1. Compose an email message in Gmail.
 2. Shift-click the diagonal-expanding-arrows icon at the top right of your compose-new-message pane. (This should pop out a smaller dialog for your email message.)
 3. Click the pocket icon in the (non-editable) URL bar for that smaller window.
 4. Observe the library icon on the top left corner

AR: Half of the library icon is shown on the top left corner (see the link below) 

https://St3fQA.tinytake.com/sf/MTk1MDcwNV82MTkyMDc4

Last good revision: 0df56be60d07b4da1b7a387b3d69aac133df928a
First bad revision: b5a5c38a0add40203d29bfe9551ce160d67e0b61
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0df56be60d07b4da1b7a387b3d69aac133df928a&tochange=b5a5c38a0add40203d29bfe9551ce160d67e0b61
Crazy bug!  I can reproduce in Linux Nightly 57.0a1 (2017-09-13) (64-bit).
Blocks: 1384953
Flags: needinfo?(jaws)
Keywords: regression
Flags: qe-verify+
Priority: P1 → --
Whiteboard: [reserve-photon-animation] → [photon-animation] [triage]
We should probably not try to run the animation if window.toolbar.visible is false.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Priority: -- → P1
Whiteboard: [photon-animation] [triage] → [reserve-photon-animation]
Attachment #8907863 - Flags: review?(gijskruitbosch+bugs)
Sorry for the wrong first-patch. I had toolkit.cosmeticAnimations.enabled=false in the testing profile and the patch of-course didn't show the animation :P
Comment on attachment 8907863 [details]
Bug 1399651 - Don't run the library animations in popup windows with toolbar=false.

https://reviewboard.mozilla.org/r/179548/#review184862
Attachment #8907863 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8d2ff3d80899
Don't run the library animations in popup windows with toolbar=false. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/8d2ff3d80899
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 20170915100121

This bug is verified as fixed with the latest Nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
No longer blocks: 1384953
Regressed by: 1384953
You need to log in before you can comment on or make changes to this bug.