1399690 - ESR compile error: failed to load source for a dependency on mp4parse_capi

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

rm -f libnetwerk_socket.a
/builds/slave/c-esr-lnx64/build/objdir/_virtualenv/bin/python /builds/slave/c-esr-lnx64/build/mozilla/config/expandlibs_gen.py -o libnetwerk_socket.a.desc Unified_cpp_netwerk_socket0.o  
make[4]: Leaving directory `/builds/slave/c-esr-lnx64/build/objdir/netwerk/socket'
force-cargo-build
make[4]: Entering directory `/builds/slave/c-esr-lnx64/build/objdir/toolkit/library/rust'
env CARGO_TARGET_DIR=. RUSTC=/builds/slave/c-esr-lnx64/build/rustc/bin/rustc /builds/slave/c-esr-lnx64/build/cargo/bin/cargo build --release --frozen --manifest-path /builds/slave/c-esr-lnx64/build/mozilla/toolkit/library/rust/Cargo.toml --target=x86_64-unknown-linux-gnu --verbose --
/builds/slave/c-esr-lnx64/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as: /lib64/libz.so.1: no version information available (required by /builds/slave/c-esr-lnx64/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as)
libnetwerk_sctp_datachannel.a.desc
rm -f libnetwerk_sctp_datachannel.a
/builds/slave/c-esr-lnx64/build/objdir/_virtualenv/bin/python /builds/slave/c-esr-lnx64/build/mozilla/config/expandlibs_gen.py -o libnetwerk_sctp_datachannel.a.desc DataChannel.o  
make[4]: Leaving directory `/builds/slave/c-esr-lnx64/build/objdir/netwerk/sctp/datachannel'
/usr/bin/ccache /builds/slave/c-esr-lnx64/build/gcc/bin/g++ -std=gnu++11 -o Unified_cpp_dom_xbl1.o -c -I/builds/slave/c-esr-lnx64/build/objdir/dist/stl_wrappers -I/builds/slave/c-esr-lnx64/build/objdir/dist/system_wrappers -include /builds/slave/c-esr-lnx64/build/mozilla/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/slave/c-esr-lnx64/build/mozilla/dom/xbl -I/builds/slave/c-esr-lnx64/build/objdir/dom/xbl -I/builds/slave/c-esr-lnx64/build/mozilla/dom/base -I/builds/slave/c-esr-lnx64/build/mozilla/dom/html -I/builds/slave/c-esr-lnx64/build/mozilla/dom/xml -I/builds/slave/c-esr-lnx64/build/mozilla/dom/xul -I/builds/slave/c-esr-lnx64/build/mozilla/layout/style -I/builds/slave/c-esr-lnx64/build/objdir/dist/include  -I/builds/slave/c-esr-lnx64/build/objdir/dist/include/nspr -I/builds/slave/c-esr-lnx64/build/objdir/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /builds/slave/c-esr-lnx64/build/objdir/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_dom_xbl1.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -g -freorder-blocks -Os -fno-omit-frame-pointer  -Werror -Wno-error=shadow  /builds/slave/c-esr-lnx64/build/objdir/dom/xbl/Unified_cpp_dom_xbl1.cpp
error: failed to load source for a dependency on `mp4parse_capi`

Caused by:
  Unable to update file:///builds/slave/c-esr-lnx64/build/mozilla/media/libstagefright/binding/mp4parse_capi

Caused by:
  failed to parse manifest at `/builds/slave/c-esr-lnx64/build/mozilla/media/libstagefright/binding/mp4parse_capi/Cargo.toml`

Caused by:
  expected a value of type `string`, but found a value of type `boolean` for the key `package.build`
make[4]: *** [force-cargo-build] Error 101
make[3]: *** [toolkit/library/rust/target] Error 2
make[3]: *** Waiting for unfinished jobs....

Comment 1

[Edmund Wong (:ewong)]

seems to have been caused by https://hg.mozilla.org/releases/mozilla-esr52/rev/21af4e17cbf9

from http://doc.crates.io/manifest.html, 

build option expects a string and it's supposed to be a .  So I don't understand why TB isn't busting.

Does TB even build with that?

:froydn,   should build = ""?

Comment 2

[Edmund Wong (:ewong)]

according to :froydnj over on irc, we're not supposed to use the latest rustc on ESR52.  Should
drop it back to 1.10.0

Comment 3

[Edmund Wong (:ewong)]

Attachment: [tooltools] downgrade rustc compiler

Comment 4

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #2)
> according to :froydnj over on irc, we're not supposed to use the latest
> rustc on ESR52.  Should
> drop it back to 1.10.0

Only for ESR52.

Comment 5

[Ian Neal]

mozilla-esr52 currently uses 1.13.0, but they haven't got https://hg.mozilla.org/releases/mozilla-esr52/rev/21af4e17cbf9

Do we know why it was required for THUNDERBIRD_52_VERBRANCH?

Comment 6

[Jorg K (CEST = GMT+2)]

You need to ask FRG. He made me land this stuff in bug 1346939 comment #29 (I'm glad I documented it):
https://hg.mozilla.org/releases/mozilla-esr52/rev/21af4e17cbf9f225e99c4103ac73a72311a702d1
(last in the lot).

Comment 7

[Frank-Rainer Grahl (:frg)]

Hmm. Need to look at it later. Should be trivial. Either we use the latest rust or we back out the change to the cargo.toml file which allows it to build with the latest rust.  I think we just back it out for the relbranch. Its a pita to build locally without it.

FRG

Comment 8

[Frank-Rainer Grahl (:frg)]

Btw. TB doesn't use it.

Comment 9

[Edmund Wong (:ewong)]

(In reply to Ian Neal from comment #5)
> mozilla-esr52 currently uses 1.13.0, but they haven't got
> https://hg.mozilla.org/releases/mozilla-esr52/rev/21af4e17cbf9
> 
> Do we know why it was required for THUNDERBIRD_52_VERBRANCH?

I don't know why it was required aside for the "please do not 
build mp4parse".  

So I'm guessing it's either remove build = false, or
downgrade rustc (which supports build = false).

Comment 10

[Frank-Rainer Grahl (:frg)]

I backed out the change in the relbranch. rust 1.13 is the current rust for Fx 52. Sorry for not checking that the patch works with this older rust. I just assumed it was backwards compatible The patch is needed when you build with a recent rust version. 

https://hg.mozilla.org/releases/mozilla-esr52/rev/c3c8a796811458695cab3922077bf53b53cee431

Please adjust the cset for the 2.49.1 release to c3c8a7968114.

Comment 11

[Jorg K (CEST = GMT+2)]

Hmm, you didn't use DONTBUILD so you caused a build of that, was that intended?

Comment 12

[Frank-Rainer Grahl (:frg)]

No sorry. I didn't read your last mail. It shouldn't hurt but wastes CPU cycles.

Comment 13

[Edmund Wong (:ewong)]

Comment on attachment 8907917 [details] [diff] [review]
[tooltools] downgrade rustc compiler

With the backout, it's no longer necessary for this patch.

Comment 14

[Edmund Wong (:ewong)]

Fixed with frg's backout.