Closed
Bug 1399699
Opened 7 years ago
Closed 7 years ago
Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd
Categories
(Firefox :: Settings UI, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-preference])
Attachments
(1 file)
After scanning http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/ folder, I still see a few colon signs haven't been removed. We should remove colon signs for: http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/cookies.dtd#7 http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd#19 http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/translation.dtd#9,16
Flags: qe-verify+
Assignee | ||
Updated•7 years ago
|
Summary: Colon sign is displayed in "about:preferences#general" page in "Color" sub-dialog → Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8907914 [details] Bug 1399699 - Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd https://reviewboard.mozilla.org/r/179588/#review185012 I went back and found https://bugzilla.mozilla.org/show_bug.cgi?id=1382135#c10 to confirm that we should be changing the IDs.
Attachment #8907914 -
Flags: review?(jaws) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3907243d5b86 Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd r=jaws
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3907243d5b86
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment 5•7 years ago
|
||
Will trying to verify this bug on nightly I confronted with some issues: 1. The first string "The following cookies are stored on your computer:" i managed somehow to find it and I confirm that the colon sign isn't displayed anymore. 2. But the rest of the string: "Translation will not be offered for the following languages:" "Translation will not be offered for the following sites:" "The following website cookies will be removed:" I couldn't fin them anywhere in "about:preferences" pages. Could you please help me figure out where I can find them? Thanks
Flags: needinfo?(rchien)
Assignee | ||
Comment 6•7 years ago
|
||
OK, some strings are only can be reached under certain conditions. I'd like to change qe-verify+ to qe-verify- since I'm confidant these string changes are robust enough.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(rchien)
Comment 7•7 years ago
|
||
Translations strings are visible in General->Languages if you enable browser.translation.ui.show in about:config. BTW, the pref looks quite broken (logo is stretched), someone should file a bug to figure out why we still have that experimental feature around. I'm not sure what happened to the Storage management section https://bugzilla.mozilla.org/show_bug.cgi?id=1312351
You need to log in
before you can comment on or make changes to this bug.
Description
•