|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
After scanning http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/ folder, I still see a few colon signs haven't been removed. We should remove colon signs for: http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/cookies.dtd#7 http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd#19 http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/translation.dtd#9,16
Summary: Colon sign is displayed in "about:preferences#general" page in "Color" sub-dialog → Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd
Comment on attachment 8907914 [details] Bug 1399699 - Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd https://reviewboard.mozilla.org/r/179588/#review185012 I went back and found https://bugzilla.mozilla.org/show_bug.cgi?id=1382135#c10 to confirm that we should be changing the IDs.
Attachment #8907914 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3907243d5b86 Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd r=jaws
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Whiteboard: [photon-preference][triage] → [photon-preference]
Will trying to verify this bug on nightly I confronted with some issues: 1. The first string "The following cookies are stored on your computer:" i managed somehow to find it and I confirm that the colon sign isn't displayed anymore. 2. But the rest of the string: "Translation will not be offered for the following languages:" "Translation will not be offered for the following sites:" "The following website cookies will be removed:" I couldn't fin them anywhere in "about:preferences" pages. Could you please help me figure out where I can find them? Thanks
OK, some strings are only can be reached under certain conditions. I'd like to change qe-verify+ to qe-verify- since I'm confidant these string changes are robust enough.
Translations strings are visible in General->Languages if you enable browser.translation.ui.show in about:config. BTW, the pref looks quite broken (logo is stretched), someone should file a bug to figure out why we still have that experimental feature around. I'm not sure what happened to the Storage management section https://bugzilla.mozilla.org/show_bug.cgi?id=1312351
You need to log in before you can comment on or make changes to this bug.