1399699 - Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

After scanning http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/ folder, I still see a few colon signs haven't been removed.

We should remove colon signs for:

http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/cookies.dtd#7

http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd#19

http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/translation.dtd#9,16

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1399699 - Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd

Review commit: https://reviewboard.mozilla.org/r/179588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179588/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8907914 [details]
Bug 1399699 - Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd

https://reviewboard.mozilla.org/r/179588/#review185012

I went back and found https://bugzilla.mozilla.org/show_bug.cgi?id=1382135#c10 to confirm that we should be changing the IDs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3907243d5b86
Remove redundant colon signs in cookies.dtd, siteDataSettings.dtd, translation.dtd r=jaws

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3907243d5b86

Comment 5

[Hani Yacoub, Desktop QA]

Will trying to verify this bug on nightly I confronted with some issues:

1. The first string "The following cookies are stored on your computer:" i managed somehow to find it and I confirm that the colon sign isn't displayed anymore.

2. But the rest of the string:
"Translation will not be offered for the following languages:"
"Translation will not be offered for the following sites:"
"The following website cookies will be removed:"

I couldn't fin them anywhere in "about:preferences" pages.

Could you please help me figure out where I can find them?
Thanks

Comment 6

[Ricky Chien [:rickychien] (inactive)]

OK, some strings are only can be reached under certain conditions. I'd like to change qe-verify+ to qe-verify- since I'm confidant these string changes are robust enough.

Comment 7

[Francesco Lodolo [:flod]]

Translations strings are visible in General->Languages if you enable browser.translation.ui.show in about:config.

BTW, the pref looks quite broken (logo is stretched), someone should file a bug to figure out why we still have that experimental feature around.

I'm not sure what happened to the Storage management section
https://bugzilla.mozilla.org/show_bug.cgi?id=1312351