Closed
Bug 1399714
Opened 7 years ago
Closed 7 years ago
Do not need to iterate animation segments twice for setting start/end values and timing functions
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file)
In AnimationHelper::SetAnimations() we are iterating over animation segments for setting timing functions and start/end values separately. It should be done in a single iteration. https://treeherder.mozilla.org/#/jobs?repo=try&revision=de99d83e73b41765c3818ca20776f081eba8567a
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8907928 [details] Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once. https://reviewboard.mozilla.org/r/179614/#review184786 ::: gfx/layers/AnimationHelper.cpp (Diff revision 1) > - // Precompute the StyleAnimationValues that we need if this is a transform > - // animation. I did drop this comment since it is not right at all, we are doing this for opacity animation too.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8907928 [details] Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once. https://reviewboard.mozilla.org/r/179614/#review184802 Nice. Looks much better.
Attachment #8907928 -
Flags: review?(boris.chiou) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thanks for the review!
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18dbc9b9340b Iterate animation segments for setting start/end values and timing functions just once. r=boris
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18dbc9b9340b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•