1399714 - Do not need to iterate animation segments twice for setting start/end values and timing functions

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

In AnimationHelper::SetAnimations() we are iterating over animation segments for setting timing functions and start/end values separately. It should be done in a single iteration.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de99d83e73b41765c3818ca20776f081eba8567a

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once.

Review commit: https://reviewboard.mozilla.org/r/179614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179614/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8907928 [details]
Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once.

https://reviewboard.mozilla.org/r/179614/#review184786

::: gfx/layers/AnimationHelper.cpp
(Diff revision 1)
> -    // Precompute the StyleAnimationValues that we need if this is a transform
> -    // animation.

I did drop this comment since it is not right at all, we are doing this for opacity animation too.

Comment 3

[Boris Chiou [:boris]]

Comment on attachment 8907928 [details]
Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once.

https://reviewboard.mozilla.org/r/179614/#review184802

Nice. Looks much better.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18dbc9b9340b
Iterate animation segments for setting start/end values and timing functions just once. r=boris

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/18dbc9b9340b