Do not need to iterate animation segments twice for setting start/end values and timing functions

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
In AnimationHelper::SetAnimations() we are iterating over animation segments for setting timing functions and start/end values separately. It should be done in a single iteration.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de99d83e73b41765c3818ca20776f081eba8567a
Comment hidden (mozreview-request)
(Assignee)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8907928 [details]
Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once.

https://reviewboard.mozilla.org/r/179614/#review184786

::: gfx/layers/AnimationHelper.cpp
(Diff revision 1)
> -    // Precompute the StyleAnimationValues that we need if this is a transform
> -    // animation.

I did drop this comment since it is not right at all, we are doing this for opacity animation too.

Comment 3

7 months ago
mozreview-review
Comment on attachment 8907928 [details]
Bug 1399714 - Iterate animation segments for setting start/end values and timing functions just once.

https://reviewboard.mozilla.org/r/179614/#review184802

Nice. Looks much better.
Attachment #8907928 - Flags: review?(boris.chiou) → review+
(Assignee)

Comment 4

7 months ago
Thanks for the review!

Comment 5

7 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18dbc9b9340b
Iterate animation segments for setting start/end values and timing functions just once. r=boris
https://hg.mozilla.org/mozilla-central/rev/18dbc9b9340b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.