Closed
Bug 1399732
Opened 8 years ago
Closed 8 years ago
[skiplist] please continue past `std::_Hash<T>::` entries
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: n.nethercote, Assigned: willkg)
Details
Attachments
(1 file)
We have various crashes, like https://crash-stats.mozilla.com/report/index/c2e8ca35-1779-4e95-aa7b-45ad60170913, that have entries such as `std::_Hash<T>::_End`. We'd like to continue signature generation past such entries.
So the following regex should be added:
> std::_Hash<T>::_End.*
willkg, are you able to do this? Thank you.
Flags: needinfo?(willkg)
Assignee | ||
Comment 1•8 years ago
|
||
I'll do this this morning.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Flags: needinfo?(willkg)
Assignee | ||
Comment 2•8 years ago
|
||
Some more example crashes so I have something to test with:
std::_Hash<T>::equal_range
https://crash-stats.mozilla.com/report/index/9086ef0f-a892-405f-9fce-89e6d0170914
std::_Hash<T>::_End
https://crash-stats.mozilla.com/report/index/c2e8ca35-1779-4e95-aa7b-45ad60170913
https://crash-stats.mozilla.com/report/index/5b075f26-9c87-4421-8a55-995730170914
std::_Hash<T>::_Insert<T>
https://crash-stats.mozilla.com/report/index/2a1937d1-00ec-4ec3-b131-353b50170914
std::_Hash<T>::lower_bound
https://crash-stats.mozilla.com/report/index/0b29cecd-fbd4-4287-8c8f-bf7c80170913
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Change in signatures looks like this:
app@f6825c359570:/app$ python -m socorro.signature 9086ef0f-a892-405f-9fce-89e6d0170914 c2e8ca35-1779-4e95-aa7b-45ad60170913 5b075f26-9c87-4421-8a55-995730170914 2a1937d1-00ec-4ec3-b131-353b50170914 0b29cecd-fbd4-4287-8c8f-bf7c80170913
Crash id: 9086ef0f-a892-405f-9fce-89e6d0170914
Original: std::_Hash<T>::equal_range
New: std::_Hash<T>::equal_range | mozilla::gfx::DrawEventRecorderPrivate::RemoveStoredObject
Same?: False
Crash id: c2e8ca35-1779-4e95-aa7b-45ad60170913
Original: std::_Hash<T>::_End
New: std::_Hash<T>::_End | std::_Hash<T>::equal_range | mozilla::gfx::DrawEventRecorderPrivate::RemoveStoredObject
Same?: False
Crash id: 5b075f26-9c87-4421-8a55-995730170914
Original: std::_Hash<T>::_End
New: std::_Hash<T>::_End | std::_Hash<T>::_Insert<T> | mozilla::gfx::DrawTargetD2D1::AddDependencyOnSource
Same?: False
Crash id: 2a1937d1-00ec-4ec3-b131-353b50170914
Original: std::_Hash<T>::_Insert<T>
New: std::_Hash<T>::_Insert<T> | stdext::hash_map<T>::operator[]
Same?: False
Crash id: 0b29cecd-fbd4-4287-8c8f-bf7c80170913
Original: std::_Hash<T>::lower_bound
New: std::_Hash<T>::lower_bound | CDevice::CreateBlendState_Worker
Same?: False
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla-services/socorro
https://github.com/mozilla-services/socorro/commit/4669539714d82ae9c54d60dcb403bd7a847726e8
fixes bug 1399732 - std::_Hash<T> (#3985)
* Fix signature TextOutput to print crash id
* Fix typo
* fixes bug 1399732 - add std::_Hash<T>.* to prefix_signature_re
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•