Closed Bug 1399751 Opened 4 years ago Closed 4 years ago

Reduce the use of MediaCacheStream::mChannelOffset

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

See bug 1398700. We want to reduce its use so we have less code to reason about its thread-safety and fixing bug 1398700 will be easier.
Assignee: nobody → jwwang
Blocks: 1398700
Priority: -- → P3
Attachment #8908430 - Flags: review?(gsquelart)
Attachment #8908431 - Flags: review?(gsquelart)
Attachment #8908432 - Flags: review?(gsquelart)
Comment on attachment 8908430 [details]
Bug 1399751. P1 - pass a block index to AllocateAndWriteBlock() so it doesn't depend on mChannelOffset.

https://reviewboard.mozilla.org/r/180068/#review185236
Attachment #8908430 - Flags: review?(gsquelart) → review+
Comment on attachment 8908431 [details]
Bug 1399751. P2 - pass a block index to FindBlockForIncomingData() so it doesn't depend on mChannelOffset.

https://reviewboard.mozilla.org/r/180070/#review185238
Attachment #8908431 - Flags: review?(gsquelart) → review+
Comment on attachment 8908432 [details]
Bug 1399751. P3 - pass the offset of range request to ChannelMediaResource::OnStartRequest().

https://reviewboard.mozilla.org/r/180072/#review185240
Attachment #8908432 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22dbe1bf55a0
P1 - pass a block index to AllocateAndWriteBlock() so it doesn't depend on mChannelOffset. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f85b473c4964
P2 - pass a block index to FindBlockForIncomingData() so it doesn't depend on mChannelOffset. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9f86654073e2
P3 - pass the offset of range request to ChannelMediaResource::OnStartRequest(). r=gerald
See Also: → 1406503
You need to log in before you can comment on or make changes to this bug.