Closed Bug 1399789 Opened 2 years ago Closed Last year

nsSubstringSplitter/nsCSubstringSplitter is not defined anymore

Categories

(Core :: String, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
This regressed after bug 1393230 landed. I found this when I was rebasing a patch in bug 1388428.
Blocks: 1393230
Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Attachment #8908014 - Flags: review?(n.nethercote)
Comment on attachment 8908014 [details] [diff] [review]
patch

Review of attachment 8908014 [details] [diff] [review]:
-----------------------------------------------------------------

I will forward onto erahm in case there's a subtlety here I'm not aware of.
Attachment #8908014 - Flags: review?(n.nethercote) → review?(erahm)
Comment on attachment 8908014 [details] [diff] [review]
patch

Review of attachment 8908014 [details] [diff] [review]:
-----------------------------------------------------------------

Oh interesting, I thought everyone used `auto` with `Split`. Looks good to me, thanks for the fix!
Attachment #8908014 - Flags: review?(erahm) → review+
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d67b9fdabf9d
Bring back nsSubstringSplitter/nsCSubstringSplitter forward declarations; r=erahm
Backed out on suspicion of causing Android build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a551e2cfcd5874f8afd579afec4cf9c1a56503cf

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=823029de25d1d3bfc3a4cad30f75effbc3aeef37&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=132174678&repo=mozilla-inbound

[task 2017-09-20T09:01:29.580Z] 09:01:29     INFO -  /builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630:34: error: invalid conversion from 'std::__ndk1::unique_ptr<std::__ndk1::__function::__base<void()>, std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()>, std::__ndk1::allocator<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()> >, void()> > > >::pointer {aka std::__ndk1::__function::__base<void()>*}' to 'std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()>, std::__ndk1::allocator<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()> >, void()> > >::pointer {aka std::__ndk1::__function::__func<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()>, std::__ndk1::allocator<EventPriorities_IdleAfterNormal_Test::TestBody()::<lambda()> >, void()>*}' [-fpermissive]
[task 2017-09-20T09:01:29.580Z] 09:01:29     INFO -               __ptr_.second()(__tmp);
[task 2017-09-20T09:01:29.581Z] 09:01:29     INFO -                                    ^
[task 2017-09-20T09:01:29.581Z] 09:01:29     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers/memory:3:0,
[task 2017-09-20T09:01:29.582Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/memory:44,
[task 2017-09-20T09:01:29.582Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/libcxx/include/algorithm:628,
[task 2017-09-20T09:01:29.582Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers/algorithm:3,
[task 2017-09-20T09:01:29.583Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/algorithm:44,
[task 2017-09-20T09:01:29.583Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Span.h:31,
[task 2017-09-20T09:01:29.584Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTSubstring.h:16,
[task 2017-09-20T09:01:29.584Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsAString.h:22,
[task 2017-09-20T09:01:29.584Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsSubstring.h:10,
[task 2017-09-20T09:01:29.585Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsString.h:14,
[task 2017-09-20T09:01:29.599Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/xpcom/tests/gtest/Helpers.h:12,
[task 2017-09-20T09:01:29.599Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/xpcom/tests/gtest/Helpers.cpp:9,
[task 2017-09-20T09:01:29.600Z] 09:01:29     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/xpcom/tests/gtest/Unified_cpp_xpcom_tests_gtest0.cpp:2:
Flags: needinfo?(jvarga)
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5ada8ce401
nsSubstringSplitter/nsCSubstringSplitter is not defined anymore; r=erahm
Flags: needinfo?(jvarga)
https://hg.mozilla.org/mozilla-central/rev/7f5ada8ce401
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.