Closed Bug 1399802 Opened 2 years ago Closed 2 years ago

RCWN: race only when disk storage is used

Categories

(Core :: Networking: Cache, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 + fixed

People

(Reporter: michal, Assigned: michal)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

[Tracking Requested - why for this release]: Blocks RCWN which should be shipped in 57
Attached patch patch (obsolete) — Splinter Review
This might also fix failures of test in dom/tests/mochitest/ajax/offline
Attachment #8908039 - Flags: review?(valentin.gosu)
Comment on attachment 8908039 [details] [diff] [review]
patch

We also need to skip racing if we're going to write to the offline cache, because we need the cache entry.
Attachment #8908039 - Attachment is obsolete: true
Attachment #8908039 - Flags: review?(valentin.gosu)
Attached patch patch v2Splinter Review
Attachment #8908064 - Flags: review?(valentin.gosu)
Local testing shows that this fixes tests in dom/tests/mochitest/ajax/offline/ as well as browser/base/content/test/general/browser_gZipOfflineChild.js.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de06dc77b97025a8aecfc0c6982b5e4e4bfb7432
Attachment #8908064 - Flags: review?(valentin.gosu) → review+
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e19ae0bc0563
Race only when disk storage is used, r=valentin
https://hg.mozilla.org/mozilla-central/rev/e19ae0bc0563
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.