Closed
Bug 1399802
Opened 7 years ago
Closed 7 years ago
RCWN: race only when disk storage is used
Categories
(Core :: Networking: Cache, defect, P1)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: michal, Assigned: michal)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 1 obsolete file)
|
4.54 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Blocks RCWN which should be shipped in 57
|
Assignee | |
Comment 1•7 years ago
|
||
This might also fix failures of test in dom/tests/mochitest/ajax/offline
Attachment #8908039 -
Flags: review?(valentin.gosu)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8908039 [details] [diff] [review]
patch
We also need to skip racing if we're going to write to the offline cache, because we need the cache entry.
Attachment #8908039 -
Attachment is obsolete: true
Attachment #8908039 -
Flags: review?(valentin.gosu)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8908064 -
Flags: review?(valentin.gosu)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Local testing shows that this fixes tests in dom/tests/mochitest/ajax/offline/ as well as browser/base/content/test/general/browser_gZipOfflineChild.js.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=de06dc77b97025a8aecfc0c6982b5e4e4bfb7432
|
||
Updated•7 years ago
|
Attachment #8908064 -
Flags: review?(valentin.gosu) → review+
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e19ae0bc0563
Race only when disk storage is used, r=valentin
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•