Closed Bug 1399870 Opened 2 years ago Closed 1 year ago
Make DEFFILE a Path instead of a string
DEFFILE isn't used in very many moz.build files, but in all but one of the places it is used it's specified as a srcdir-relative path with the ugly construct `SRCDIR + '/file.def'`. Given that, we might as well make it a Path instead of a string, so that srcdir-relative paths just work. This makes my WSL build easier, because I can translate it to a relative path to pass to link.exe.
Comment on attachment 8908133 [details] bug 1399870 - Make DEFFILE a Path instead of a string. https://reviewboard.mozilla.org/r/179812/#review185566
Attachment #8908133 - Flags: review?(gps) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/52e6fce3e6f6 Make DEFFILE a Path instead of a string. r=gps
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/98e46ead3522 Fix test for DEFFILE; r=me
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1a79683f59bc Backed out changesets 98e46ead3522 and 52e6fce3e6f6 for Windows test failures; a=backout
This is Ted's patch, but rebased and changed so things will build. It *does* rely on the patch in bug 1490054, which is presumably what was causing the previous Windows test failures. Enough bitrot etc. means this is probably worth looking at again.
Attachment #9007827 - Flags: review?(gps)
Comment on attachment 9007827 [details] [diff] [review] make DEFFILE a Path instead of a string gps had reviewed this before, but this can probably go into the general build pool.
Attachment #9007827 - Flags: review?(gps) → review?(core-build-config-reviews)
Attachment #9007827 - Flags: review?(core-build-config-reviews) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b8dd6f38524 make DEFFILE a Path instead of a string; r=gps
You need to log in before you can comment on or make changes to this bug.