Closed Bug 1399870 Opened 4 years ago Closed 3 years ago

Make DEFFILE a Path instead of a string


(Firefox Build System :: General, enhancement)

Not set


(firefox57 wontfix, firefox64 fixed)

Tracking Status
firefox57 --- wontfix
firefox64 --- fixed


(Reporter: ted, Assigned: ted)




(1 file, 1 obsolete file)

DEFFILE isn't used in very many files, but in all but one of the places it is used it's specified as a srcdir-relative path with the ugly construct `SRCDIR + '/file.def'`. Given that, we might as well make it a Path instead of a string, so that srcdir-relative paths just work.

This makes my WSL build easier, because I can translate it to a relative path to pass to link.exe.
Comment on attachment 8908133 [details]
bug 1399870 - Make DEFFILE a Path instead of a string.
Attachment #8908133 - Flags: review?(gps) → review+
Pushed by
Make DEFFILE a Path instead of a string. r=gps
Backout by
Backed out changesets 98e46ead3522 and 52e6fce3e6f6 for Windows test failures; a=backout
Product: Core → Firefox Build System
This is Ted's patch, but rebased and changed so things will build.  It *does*
rely on the patch in bug 1490054, which is presumably what was causing the
previous Windows test failures.

Enough bitrot etc. means this is probably worth looking at again.
Attachment #9007827 - Flags: review?(gps)
Attachment #8908133 - Attachment is obsolete: true
Depends on: 1490054
Comment on attachment 9007827 [details] [diff] [review]
make DEFFILE a Path instead of a string

gps had reviewed this before, but this can probably go into the general build pool.
Attachment #9007827 - Flags: review?(gps) → review?(core-build-config-reviews)
Attachment #9007827 - Flags: review?(core-build-config-reviews) → review+
Pushed by
make DEFFILE a Path instead of a string; r=gps
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.