1399870 - Make DEFFILE a Path instead of a string

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

DEFFILE isn't used in very many moz.build files, but in all but one of the places it is used it's specified as a srcdir-relative path with the ugly construct `SRCDIR + '/file.def'`. Given that, we might as well make it a Path instead of a string, so that srcdir-relative paths just work.

This makes my WSL build easier, because I can translate it to a relative path to pass to link.exe.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: bug 1399870 - Make DEFFILE a Path instead of a string.

DEFFILE is currently just used as a passthrough variable. All but one of
the current uses of it use `SRCDIR + '/file.def'` to get a srcdir-relative
path anyway, and the other one wants an objdir-relative path, so using
Path makes everything clearer.

This makes it more straightforward to translate the paths for the WSL
build.

Review commit: https://reviewboard.mozilla.org/r/179812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179812/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8908133 [details]
bug 1399870 - Make DEFFILE a Path instead of a string.

https://reviewboard.mozilla.org/r/179812/#review185566

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e6fce3e6f6
Make DEFFILE a Path instead of a string. r=gps

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e46ead3522
Fix test for DEFFILE; r=me

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a79683f59bc
Backed out changesets 98e46ead3522 and 52e6fce3e6f6 for Windows test failures; a=backout

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: make DEFFILE a Path instead of a string

This is Ted's patch, but rebased and changed so things will build.  It *does*
rely on the patch in bug 1490054, which is presumably what was causing the
previous Windows test failures.

Enough bitrot etc. means this is probably worth looking at again.

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 9007827 [details] [diff] [review]
make DEFFILE a Path instead of a string

gps had reviewed this before, but this can probably go into the general build pool.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b8dd6f38524
make DEFFILE a Path instead of a string; r=gps

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5b8dd6f38524