1399935 - Customize Mode > Use only the left-side orientation for the option panel for the Downloads menu when in the grid

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Aaron Benson]

The option panel for the Downloads Menu shows above the download icon when it's in the icon grid. The style looks a bit off from the other orientation so let's just have it show up on the left hand side all the time since this is likely to be the most common orientation people see.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1399935 - use horizontal panel for downloads checkbox panel at all times,

Rather than using left-hand-side at all times (which can go over the edge of the window
in some cases) this uses left or right-hand-side panels, always opening towards the
center of the window.

Review commit: https://reviewboard.mozilla.org/r/180732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180732/

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8909155 [details]
Bug 1399935 - use horizontal panel for downloads checkbox panel at all times,

https://reviewboard.mozilla.org/r/180732/#review185968

::: browser/base/content/browser.css:187
(Diff revision 1)
>  .tabbrowser-tab[tabdrop-samewindow],
>  .tabbrowser-tabs[movingtab] > .tabbrowser-tab[fadein]:not([selected]) {
>    transition: transform 200ms var(--animation-easing-function);
>  }
>  
> -#TabsToolbar[movingtab] > .chromeclass-toolbar-additional,
> +#TabsToolbar[movingtab] {

As discussed over IRC, these browser.css change are in the wrong changeset and should be removed from here

::: browser/components/customizableui/CustomizeMode.jsm:2375
(Diff revision 1)
> -      checkbox.removeAttribute("checked");
> -    }
> -
>      let offsetX = 0, offsetY = 0;
> -    let position;
> +    let panelOnTheLeft = false;
> +    let buttonIsOnToolbar = false;

nit: could just initialize it to button.closest("toolbar") and save a couple lines of code, unless it's expensive, but doesn't look like a problem.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8909155 [details]
Bug 1399935 - use horizontal panel for downloads checkbox panel at all times,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180732/diff/1-2/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8909155 [details]
Bug 1399935 - use horizontal panel for downloads checkbox panel at all times,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180732/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d2984916128
use horizontal panel for downloads checkbox panel at all times, r=mak

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d2984916128

Comment 7

[Emil Ghitta, QA [:emilghitta]]

I have reproduced the issue mentioned in comment 0 using an affected Firefox 57.0a1 build (BuildId:20170914220255).

I have verified that the issue is not reproducible using Firefox 57.0b7 (Build Id:20171009192146) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.