1399959 - Set preference to prefer hardware U2F tokens (but not shipping any U2F/WebAuthn APIs)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P2)

Description

[J.C. Jones [:jcj] (he/they)]

The general case of enabling U2F / WebAuthn should only require flipping one pref, not two or three. Let's leave u2f and webauthn off (because not ready to ship), but change 

pref("security.webauth.webauthn_enable_softtoken", false);
pref("security.webauth.webauthn_enable_usbtoken", false);


to

pref("security.webauth.webauthn_enable_softtoken", false);
pref("security.webauth.webauthn_enable_usbtoken", true);

Comment 1

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1399959 - Prefer hardware instead of software U2F tokens

Bug 1388851 adds hardware U2F support to Gecko; the instructions to test
involve flipping two prefs, but the common case will be using harwdare tokens,
so this patch makes users only haave to flip the "security.webauth.u2f" or
"security.webauth.webauthn" prefs as they choose.

Review commit: https://reviewboard.mozilla.org/r/179908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179908/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8908258 [details]
Bug 1399959 - Prefer hardware instead of software U2F tokens

https://reviewboard.mozilla.org/r/179908/#review185146

Sounds good.

::: security/manager/ssl/security-prefs.js:119
(Diff revision 1)
>  pref("security.pki.certificate_transparency.mode", 0);
>  
> +// Hardware Origin-bound Second Factor Support
>  pref("security.webauth.u2f", false);
>  pref("security.webauth.webauthn", false);
> +// Only one of "enable_softtoken" and "enable_usbtoken" can be true

Do we have code that enforces this?

Comment 3

[J.C. Jones [:jcj] (he/they)]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> Comment on attachment 8908258 [details]
> Bug 1399959 - Prefer hardware instead of software U2F tokens
> 
> https://reviewboard.mozilla.org/r/179908/#review185146
> 
> Sounds good.
> 
> ::: security/manager/ssl/security-prefs.js:119
> (Diff revision 1)
> >  pref("security.pki.certificate_transparency.mode", 0);
> >  
> > +// Hardware Origin-bound Second Factor Support
> >  pref("security.webauth.u2f", false);
> >  pref("security.webauth.webauthn", false);
> > +// Only one of "enable_softtoken" and "enable_usbtoken" can be true
> 
> Do we have code that enforces this?

We do: http://searchfox.org/mozilla-central/source/dom/webauthn/U2FTokenManager.cpp#208

Thanks for the review!

Comment 4

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8908258 [details]
Bug 1399959 - Prefer hardware instead of software U2F tokens

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179908/diff/1-2/

Comment 5

[J.C. Jones [:jcj] (he/they)]

This is a pref change that doesn't ship anything, just makes for easier testing. Try run looks good [1]

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f454fa9a0da3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b406b52fd2e3
Prefer hardware instead of software U2F tokens r=keeler

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b406b52fd2e3