Closed Bug 1399989 Opened 2 years ago Closed 2 years ago

Add python/mach to flake8 linter

Categories

(Firefox Build System :: Mach Core, enhancement)

57 Branch
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ahal, Assigned: stevea1, Mentored)

Details

Attachments

(1 file)

For this we'll need to:
1. Add 'python/mach' to 'tools/lint/flake8.yml'.
2. Run ./mach lint -l flake8 python/mach
3. Fix all the reported errors.

I'm happy to provide guidance and feedback, but final review should go to :gps.
Assignee: nobody → stevea1
Status: NEW → ASSIGNED
I cleaned up all of the flake8 reported errors. I confirmed things still worked by running ./mach python-test python/mach afterwards.
Comment on attachment 8909174 [details]
Bug 1399989 - Add python/mach to flake8 linter.

https://reviewboard.mozilla.org/r/180744/#review186164
Attachment #8909174 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81ae370514fd
Add python/mach to flake8 linter. r=gps
https://hg.mozilla.org/mozilla-central/rev/81ae370514fd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.