Closed Bug 1400059 Opened 2 years ago Closed 2 years ago

Replace strings in ProgressListener.SecurityInformation with static ints

Categories

(GeckoView :: General, enhancement)

53 Branch
All
Android
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

Attachments

(1 file)

We should get rid of the strings in SecurityInformation.
Update securityMode, trackingMode, mixedModeActive, and mixedModePassive in SecurityInformation to no longer be strings.
Attachment #8908387 - Flags: review?(snorp)
Comment on attachment 8908387 [details] [diff] [review]
Remove strings from SecurityInformation

Review of attachment 8908387 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/geckoview/GeckoViewProgress.jsm
@@ +24,5 @@
>  }
>  
>  var IdentityHandler = {
>    // No trusted identity information. No site identity icon is shown.
> +  IDENTITY_MODE_UNKNOWN: 0,

Should probably add a comment that these values need to be kept in sync with those in GeckoView
Attachment #8908387 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff8b9eddddc4
Replace strings in ProgressListener.SecurityInformation with ints. r=snorp
https://hg.mozilla.org/mozilla-central/rev/ff8b9eddddc4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 57 → mozilla57
You need to log in before you can comment on or make changes to this bug.