1400059 - Replace strings in ProgressListener.SecurityInformation with static ints

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Dylan Roeh (:droeh) (he/him)]

We should get rid of the strings in SecurityInformation.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Remove strings from SecurityInformation

Update securityMode, trackingMode, mixedModeActive, and mixedModePassive in SecurityInformation to no longer be strings.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8908387 [details] [diff] [review]
Remove strings from SecurityInformation

Review of attachment 8908387 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/geckoview/GeckoViewProgress.jsm
@@ +24,5 @@
>  }
>  
>  var IdentityHandler = {
>    // No trusted identity information. No site identity icon is shown.
> +  IDENTITY_MODE_UNKNOWN: 0,

Should probably add a comment that these values need to be kept in sync with those in GeckoView

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff8b9eddddc4
Replace strings in ProgressListener.SecurityInformation with ints. r=snorp

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/613e05258559
Fix trailing whitespace r=me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff8b9eddddc4

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/613e05258559