Closed Bug 140006 Opened 22 years ago Closed 22 years ago

ThrowTemplateError should try the error template first

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
2.15
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: bbaetz, Assigned: gerv)

Details

(Keywords: polish)

Attachments

(1 file)

Patch v.1
1.87 KB, patch
bbaetz
: review+
justdave
: review+
Details | Diff | Splinter Review 
Currently, ThrowTemplateError assuems that we're doomed. This means that we get
a plain error no matter what went wrong. We should try to use the error
template, and give a nicely formatted error, and only fall back to untemplated
output as a last resort.
Keywords: polish
Yep, true. I'll whip up a patch this evening.

Gerv
Target Milestone: --- → Bugzilla 2.16
Attached patch Patch v.1 — — Splinter Review 
It's not even as big as it looks; I just wrapped the old print statements in an
attempt to use the code-error.html.tmpl template, and recorded both errors in
the printed error message.

Gerv
Keywords: patch, review
Comment on attachment 80987 [details] [diff] [review]
Patch v.1

diff -w is often helpful for patches with large whitespace changes.

r=bbaetz
Attachment #80987 - Flags: review+
Comment on attachment 80987 [details] [diff] [review]
Patch v.1

r= justdave
Attachment #80987 - Flags: review+
Fixed.

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.150; previous revision: 1.149
done

Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.