140006 - ThrowTemplateError should try the error template first

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Bradley Baetz (:bbaetz)]

Currently, ThrowTemplateError assuems that we're doomed. This means that we get
a plain error no matter what went wrong. We should try to use the error
template, and give a nicely formatted error, and only fall back to untemplated
output as a last resort.

Comment 1

[Gervase Markham [:gerv]]

Yep, true. I'll whip up a patch this evening.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

It's not even as big as it looks; I just wrapped the old print statements in an
attempt to use the code-error.html.tmpl template, and recorded both errors in
the printed error message.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 80987 [details] [diff] [review]
Patch v.1

diff -w is often helpful for patches with large whitespace changes.

r=bbaetz

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 80987 [details] [diff] [review]
Patch v.1

r= justdave

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.150; previous revision: 1.149
done

Gerv