Closed Bug 1400092 Opened 2 years ago Closed 2 years ago

stylo: deal with @-moz-document rule in forms.css

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: heycam, Assigned: dao)

References

Details

Attachments

(1 file)

In bug 1362532, we are sharing CascadeData across documents for UA level sheets.  There is one instance of a @-moz-document rule in a UA sheet here:

http://searchfox.org/mozilla-central/source/layout/style/res/forms.css#120

We should either support @-moz-document rules in EffectiveMediaQueryResults so that we can correctly have separate cache entries for whether that @-moz-document rule matched, or we should use some other mechanism for those couple of rules in forms.css.
I'm unsure why that rule is there in the first place, seems weird that we have location-bar specific code in an UA sheet.

Dao, Gijs, do you know why this is there? Can / should it be moved to a more specific stylesheet?
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(dao+bmo)
I think this was originally put in forms.css because chrome stylesheets can't access .anonymous-div. It looks like this rule doesn't select .anonymous-div anymore, so I suppose we could move it.
Flags: needinfo?(dao+bmo)
(In reply to Dão Gottwald [::dao] from comment #2)
> I think this was originally put in forms.css because chrome stylesheets
> can't access .anonymous-div. It looks like this rule doesn't select
> .anonymous-div anymore, so I suppose we could move it.

Moving it would be nice, since it'd avoid having a whole new set of style data structures for chrome and non-chrome documents, and they could be shared.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment on attachment 8908607 [details]
Bug 1400092 - Move RTL direction and aligment styling for the location bar input field to a chrome stylesheet since it doesn't need to access .anonymous-div anymore.

https://reviewboard.mozilla.org/r/180276/#review185424

rs=me
Attachment #8908607 - Flags: review?(gijskruitbosch+bugs) → review+
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/753a7798aae8
Move RTL direction and aligment styling for the location bar input field to a chrome stylesheet since it doesn't need to access .anonymous-div anymore. r=Gijs
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/753a7798aae8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.