1400150 - Use Swtichboard to enable Leanplum debugging

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, enhancement)

Description

[Nevin Chen(Not active on Bugzilla)]

When we debug Leanlpum, we need to know the user's Leanplum user id.
This bug is to create a user id for debugging so that we can set it in Leanplum backend and test againstt it.

The only way to use this is via Switchboard. It will always to be false in Kinto, but testers can enable it using switchboard add-on(with very tedious setup steps.)

This will largely help our testers (SV mainly) to test issues.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Please note, this debugging user id needs to be setup before first use.
This is because Leanplum SDK will cache that user ID during SDK initialization.[1]

So when first setting up switchboard add-on in about:experiments, you need to enable it(leanplum-debug) with leanplum-start

I've requested Kinto update and approved by Jing Wei.


The test preparation SOP will be
1. Clean install
2. Install Switchboard add-on
3. enable leanplum-start and leanpum-debug
4. you will have a fixed user id , e.g. 8effda84-99df-11e7-abc4-cec278b6b50a
5. we can use this user id in LP backend and target it as the only user and test messages on it. 

All the device with this test user id will see the same dialog.
But only the last started device will receive the push message (Since it'll override the device push token for the test user id).


[1] http://searchfox.org/mozilla-central/rev/2c9a5993ac40ec1db8450e3e0a85702fa291b9e2/mobile/android/thirdparty/com/leanplum/internal/VarCache.java#360

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1400150 - Use Swtichboard to enable Leanplum debugging.

Review commit: https://reviewboard.mozilla.org/r/180176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180176/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8908541 [details]
Bug 1400150 - Use Swtichboard to enable Leanplum debugging.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180176/diff/1-2/

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8908541 [details]
Bug 1400150 - Use Swtichboard to enable Leanplum debugging.

https://reviewboard.mozilla.org/r/180176/#review186014

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java:101
(Diff revision 2)
>                          mmaHelper.setGcmSenderId(PushManager.getSenderIds());
> +                        mmaHelper.setDeviceId(getDeviceId(activity));

Add a comment indicates these two config setup required to be invoked before Leanplum.start in mmaHelper.init.

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java:197
(Diff revision 2)
> +    private static String getDeviceId(Activity activity) {
> +        if (SwitchBoard.isInExperiment(activity, Experiments.LEANPLUM_DEBUG)) {
> +            return DEBUG_LEANPLUM_DEVICE_ID;
> +        }
> +
> +        final SharedPreferences sharedPreferences = activity.getPreferences(0);

replace 0 as MODE_PRIVATE

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8908541 [details]
Bug 1400150 - Use Swtichboard to enable Leanplum debugging.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180176/diff/2-3/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Tested on Pixel C, Nexus 5, Pixel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3045288dcb2e
Use Swtichboard to enable Leanplum debugging. r=maliu

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3045288dcb2e