1400164 - (photon) New tabs open with the close button invisible, on tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Oana Horvath [:ohorvath]]

Attachment: rec1.mp4

[Tracking Requested - why for this release]:

Device:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Lenovo Yoga Tablet 2 (Android 4.4.2)

Build: Nightly 57.0a1 (2017-09-14);

Steps to reproduce:
1. Tap the + button and add 2-3 new tabs.
2. Observe the x (close) button on the new empty tabs.

Expected result:
All tabs should have a visible close button.

Actual result:
The new empty tabs have an invisible close button.
The button will sometimes appear back if you tap the tab, but not always (see the last tab tapped in the recording attached).

Note:
Not reproducing with themes added.
Not reproducing by opening links in new tabs.

Comment 1

[Ioana Chiorean]

I am not reproducing this with :
- Pixel C (Android 7.1.1)
- Galaxy Not Pro (Android 5.0.2)

Comment 2

[Wesly Huang (EPM)]

Jingwei, I don't think it's blocking the entering of beta, but would you help check this with the devices you have in hand? Thanks!

Comment 3

[Jing-wei Wu [:jwu]]

No problem, I would file a patch for reviewing ASAP.

Comment 4

[Jing-wei Wu [:jwu]]

Attachment: Bug 1400164 - Part 1: Provide a getter method for tint colors of themed widgets.

Review commit: https://reviewboard.mozilla.org/r/180756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180756/

Comment 5

[Jing-wei Wu [:jwu]]

Attachment: Bug 1400164 - Part 2: Tint close button manually when checked status is changed.

Because without implementing 'Checkable' interface, ThemedImageButton doesn't refresh its
drawable when the 'checked' status is changed.

We have to tint the drawable and set into the view manually.

Review commit: https://reviewboard.mozilla.org/r/180758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180758/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8909179 [details]
Bug 1400164 - Part 1: Provide a getter method for tint colors of themed widgets.

https://reviewboard.mozilla.org/r/180756/#review185876

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8909180 [details]
Bug 1400164 - Part 2: Tint close button manually when checked status is changed.

https://reviewboard.mozilla.org/r/180758/#review185878

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff594f5d6356
Part 1: Provide a getter method for tint colors of themed widgets. r=nechen
https://hg.mozilla.org/integration/autoland/rev/e015f756f2fc
Part 2: Tint close button manually when checked status is changed. r=nechen

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff594f5d6356
https://hg.mozilla.org/mozilla-central/rev/e015f756f2fc

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed in Nightly 57 (2017-09-21).
Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)