Closed
Bug 1400289
Opened 7 years ago
Closed 7 years ago
Move release documentation in tree
Categories
(Testing :: geckodriver, enhancement, P1)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
We have a wiki page at
https://github.com/mozilla/geckodriver/wiki/Releasing which should
be moved in tree. It is also somewhat out of date now that
geckodriver lives in tree and needs a couple of updates.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P1
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8908973 [details]
Bug 1400289 - Add geckodriver release instructions.
https://reviewboard.mozilla.org/r/180572/#review185918
Attachment #8908973 -
Flags: review?(dburns) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8908973 [details]
Bug 1400289 - Add geckodriver release instructions.
https://reviewboard.mozilla.org/r/180572/#review185932
::: testing/geckodriver/doc/Releasing.md:67
(Diff revision 3)
> +mention of this. Lines are optimally formatted at roughly 72 columns
> +to make the file readable in a text editor as well as rendered HTML.
> +fmt(1) does a splendid job at text formatting.
> +
> +[CHANGES.md]: ../CHANGES.md
> +[webdriver]: ../webdriver
Shouldn't this be 2 levels up?
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8908973 [details]
Bug 1400289 - Add geckodriver release instructions.
https://reviewboard.mozilla.org/r/180572/#review185932
> Shouldn't this be 2 levels up?
Yes it should. Good catch!
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
So, someone really need a git checkout and git to do a release? How would it work with Mercurial and git cinnabar? I asked because that is what most people are using.
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #8)
> So, someone really need a git checkout and git to do a
> release? How would it work with Mercurial and git cinnabar? I
> asked because that is what most people are using.
Mercurial won’t work with checking out
httsp://github.com/mozilla/geckodriver.git unless there is a
backend, like the reverse of cinnabar, that allows Mercurial to talk
directly with git remotes.
So you need git to export testing/geckodriver/* from m-c into the
repo where Travis does releases from.
Comment 10•7 years ago
|
||
I see, so a partial checkout is possible and I don't have to clone the complete repo?
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #10)
> I see, so a partial checkout is possible and I don't have to clone
> the complete repo?
I don’t understand the question. Cloning
https://github.com/mozilla/geckodriver.git is not a big overhead.
Comment 12•7 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #11)
> I don’t understand the question. Cloning
> https://github.com/mozilla/geckodriver.git is not a big overhead.
It's not about cloning the geckodriver repository but:
> So you need git to export testing/geckodriver/* from m-c into the
repo where Travis does releases from.
Maybe git cinnabar can export such a patch from a hg repository which then can be imported in geckodriver.
Anyway, it's something which should not hold us off from landing this patch.
Assignee | ||
Comment 13•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #12)
> (In reply to Andreas Tolfsen ‹:ato› from comment #11)
>
> > I don’t understand the question. Cloning
> > https://github.com/mozilla/geckodriver.git is not a big
> > overhead.
>
> It's not about cloning the geckodriver repository but:
>
> > So you need git to export testing/geckodriver/* from m-c into
> > the repo where Travis does releases from.
>
> Maybe git cinnabar can export such a patch from a hg repository
> which then can be imported in geckodriver.
>
> Anyway, it's something which should not hold us off from landing
> this patch.
I think you may have misread the documentation. You don’t need
git-cinnabar to do any of these steps. You can use hg, git, or
git-cinnabar for your m-c checkout. You need git to check code into
the GitHub geckodriver repository.
Comment 14•7 years ago
|
||
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/760c49597860
Add geckodriver release instructions. r=automatedtester
Comment 15•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•