Closed Bug 1400329 Opened 2 years ago Closed 2 years ago

stylo-disabled tests aren't being scheduled on Beta after yesterday's uplift of Gecko 57

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla57

People

(Reporter: RyanVM, Assigned: jryans)

References

Details

(Whiteboard: [Stylo])

Attachments

(1 file)

Other than a handful on Win10 debug jobs for some reason, stylo-disabled tests aren't running on Beta since yesterday's uplift of Gecko 57 to it. I assume we want them running on the off chance we find ourselves needing to pull Stylo from the 57 release.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&filter-searchStr=stylo%20disabled&fromchange=c38455951db4121afd705adadadebe55f039578d
Flags: needinfo?(jryans)
I bet this is because the tests.yml file has .*-stylo-.* for [autoland, m-c, try]:
http://searchfox.org/mozilla-central/source/taskcluster/ci/test/tests.yml#588
we would need to adjust that for all the different tests!
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Comment on attachment 8910480 [details]
Bug 1400329 - Run stylo-disabled for default branches.

You can just use 'release' I believe instead of listing both branches explicitly.
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/util/attributes.py#71

While you're at it, you could fix the scheduling here with 'trunk' so that these Tier 1 jobs are running on inbound too. I know that's burned us at least once already.
Comment on attachment 8910480 [details]
Bug 1400329 - Run stylo-disabled for default branches.

https://reviewboard.mozilla.org/r/181910/#review187260

thanks for doing this, I had forgotten to do this the other day.
Attachment #8910480 - Flags: review?(jmaher) → review+
Comment on attachment 8910480 [details]
Bug 1400329 - Run stylo-disabled for default branches.

https://reviewboard.mozilla.org/r/181910/#review187268

::: taskcluster/ci/test/tests.yml:1254
(Diff revision 1)
>      treeherder-symbol: tc-T(c)
>      virtualization: hardware
>      run-on-projects:
>          by-test-platform:
>              linux64-qr/.*: ['mozilla-central', 'try']
> -            .*-stylo.*: ['mozilla-central', 'try']
> +            .*-stylo.*: ['mozilla-release', 'mozilla-beta', 'mozilla-central', 'try']

Just noticed the `default` value doesn't include `release` for Talos, so no need to add it for `stylo-disabled`.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Comment on attachment 8910480 [details]
> Bug 1400329 - Add release and beta to stylo-disabled tests.
> 
> You can just use 'release' I believe instead of listing both branches
> explicitly.
> https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/util/
> attributes.py#71

Thanks for the tip, I think I'll clean them up in an extra commit.

> While you're at it, you could fix the scheduling here with 'trunk' so that
> these Tier 1 jobs are running on inbound too. I know that's burned us at
> least once already.

This part I am less sure about, since I believe we've been avoiding inbound at least for macOS to save resources.  Do you really want me to add inbound for all stylo-disabled on all platforms?  Or maybe just add inbound to Windows and Linux only?
Flags: needinfo?(ryanvm)
Yeah, you're right that Linux and Windows only would probably be better from a load standpoint. On the other hand, we *do* have coalescing now for OSX tests scheduled with Taskcluster, so maybe it's not as big of a deal? Joel?
Flags: needinfo?(ryanvm) → needinfo?(jmaher)
we have coalescing on osx, that will help, if we have load issues, we can optimize- I would rather get full coverage if possible.
Flags: needinfo?(jmaher)
Comment on attachment 8910480 [details]
Bug 1400329 - Run stylo-disabled for default branches.

Please re-review.
Attachment #8910480 - Flags: review+ → review?(jmaher)
Whiteboard: [Stylo]
Comment on attachment 8910480 [details]
Bug 1400329 - Run stylo-disabled for default branches.

https://reviewboard.mozilla.org/r/181910/#review187338

ok, this makes a lot more sense- if we land this tomorrow we can watch the trees and adjust any platforms that need scaling back
Attachment #8910480 - Flags: review?(jmaher) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2cc4059e5d00 -d 0f882496ac42: rebasing 421766:2cc4059e5d00 "Bug 1400329 - Run stylo-disabled for default branches. r=jmaher" (tip)
merging taskcluster/ci/test/tests.yml
warning: conflicts while merging taskcluster/ci/test/tests.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2253d1020de5
Run stylo-disabled for default branches. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/2253d1020de5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.