1400347 - Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Ryan just told me that flipping the pref causes this test to fail on android:

https://treeherder.mozilla.org/logviewer.html#?job_id=131280913&repo=try&lineNumber=2160

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1400347_android_test.patch

Other tests within mobile/android/components/extensions/test/mochitest use a similar pattern, see [1].

[1] https://dxr.mozilla.org/mozilla-central/search?q=const+BASE+%3D+%22http%3A%2F%2Fmochi.test%3A8888%2Ftests%2Fmobile%2Fandroid&redirect=false

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/906b8bdd2002
Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy. r=smaug

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1400347 and bug 1380959 for failing talos tpaint:

bug 1380959: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d5650ab1aeca067c7b21584e73813761ffc4dca
bug 1400347: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6381a51810fed75d99cdf04b6735abfe78922a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=906b8bdd2002b75be1ec731694d818b7aff02187&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=131354755&repo=mozilla-inbound

12:36:01     INFO -  TEST-INFO | started process 13826 (/builds/slave/test/build/application/firefox/firefox -profile /tmp/tmp1v003p/profile -tp file:/builds/slave/test/build/tests/talos/talos/tests/tpaint/tpaint.manifest.develop -tpchrome -tpmozafterpaint -tpnoisy -tpcycles 1 -tppagecycles 20)
12:36:02     INFO -  PID 13826 |
12:36:02     INFO -  PID 13826 | (/builds/slave/test/build/application/firefox/firefox:13875): Pango-WARNING **: error opening config file '/home/cltbld/.pangorc': Permission denied
12:36:02     INFO -  PID 13826 |
12:36:12     INFO -  PID 13826 | RSS: Main: 179146752
12:36:12     INFO -  PID 13826 |
12:41:01     INFO -  Timeout waiting for test completion; killing browser...
12:41:01     INFO -  Terminating psutil.Process(pid=13826, name='firefox')
12:41:01     INFO -  PID 13826 | ExceptionHandler::GenerateDump cloned child 13962
12:41:01     INFO -  PID 13826 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
12:41:01     INFO -  PID 13826 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
12:41:01     INFO -  TEST-UNEXPECTED-ERROR | tpaint | timeout
12:41:01    ERROR -  Traceback (most recent call last):
12:41:01     INFO -    File "/builds/slave/test/build/tests/talos/talos/run_tests.py", line 281, in run_tests
12:41:01     INFO -      talos_results.add(mytest.runTest(browser_config, test))
12:41:01     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 61, in runTest
12:41:01     INFO -      return self._runTest(browser_config, test_config, setup)
12:41:01     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 209, in _runTest
12:41:01     INFO -      if counter_management else None),
12:41:01     INFO -    File "/builds/slave/test/build/tests/talos/talos/talos_process.py", line 130, in run_browser
12:41:01     INFO -      raise TalosError("timeout")
12:41:01     INFO -  TalosError: timeout

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #4)
> Backed out bug 1400347 and bug 1380959 for failing talos tpaint:

Sorry for the bustage!

Bug 1380959 causes the problems for talos tpaint - this patch is fine to land.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0659ef1d09b2
Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy. r=bz

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/eb321219373e - apparently you'll have to do something about Android, because https://treeherder.mozilla.org/logviewer.html#?job_id=131431501&repo=mozilla-inbound

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1400347_android_tests.patch

(In reply to Phil Ringnalda (:philor) from comment #7)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/eb321219373e -
> apparently you'll have to do something about Android, because
> https://treeherder.mozilla.org/logviewer.html#?job_id=131431501&repo=mozilla-
> inbound

Olli, I guess I was a little too hasty Friday Night and missed the dynamic parts of that test, like: ${options.color}

Instead of rewriting I think it's easier to use pushPrefEnv. At this point I am not entirely sure if that works because grepping for "SpecialPowers.pushPrefEnv" does not return any result within mobile/android/components/extensions/test/mochitest.

If you are fine with that approach I will check on TRY obviously before pushing to inbound.

Agreed?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eed51cc2228
Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy. r=smaug

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5eed51cc2228