1400489 - Restrict global sharing to desktop

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Kris Maglione [:kmag]]

Android currently passes cross-JSM syntactic scope objects, which don't fare very well.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1400489: Restrict global sharing to desktop Firefox.

Review commit: https://reviewboard.mozilla.org/r/180560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180560/

Comment 2

[Ted Campbell [:tcampbell]]

Comment on attachment 8908944 [details]
Bug 1400489: Restrict global sharing to desktop Firefox.

https://reviewboard.mozilla.org/r/180560/#review185692

Desktop benefits most from JSM sharing so lets defer Fennec support, especially since very recent changes are incompatible and we need to get update from that team.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2832e30d354
Restrict global sharing to desktop Firefox. r=tcampbell

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a2832e30d354

Comment 5

[Ionuț Goldan [:igoldan]]

This canceled the improvements noticed on Android in https://bugzilla.mozilla.org/show_bug.cgi?id=1381961#c16

== Change summary for alert #9501 (as of September 16 2017 04:29 UTC) ==

Regressions:

 39%  remote-blank summary android-4-4-armv7-api16 opt      816.48 -> 1,131.97
 24%  remote-blank summary android-7-1-armv8-api16 opt      506.68 -> 630.01
 22%  remote-blank summary android-4-2-armv7-api16 opt      1,257.64 -> 1,537.36
 18%  remote-twitter summary android-4-4-armv7-api16 opt    1,215.80 -> 1,435.96
 17%  remote-nytimes summary android-4-4-armv7-api16 opt    1,875.75 -> 2,201.11
 16%  remote-twitter summary android-7-1-armv8-api16 opt    809.18 -> 937.04
 13%  remote-nytimes summary android-7-1-armv8-api16 opt    1,169.54 -> 1,327.35

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9501

Comment 6

[Ionuț Goldan [:igoldan]]

Will global sharing be re-enabled for Android? I want to file a dedicated tracking bug, to closely watch these improvements.

Comment 7

[Andrew McCreight [:mccr8]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> Will global sharing be re-enabled for Android? I want to file a dedicated
> tracking bug, to closely watch these improvements.

I've filed bug 1400886 for enabling this on Android.