Closed Bug 1400489 Opened 3 years ago Closed 3 years ago

Restrict global sharing to desktop

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

Android currently passes cross-JSM syntactic scope objects, which don't fare very well.
Comment on attachment 8908944 [details]
Bug 1400489: Restrict global sharing to desktop Firefox.

https://reviewboard.mozilla.org/r/180560/#review185692

Desktop benefits most from JSM sharing so lets defer Fennec support, especially since very recent changes are incompatible and we need to get update from that team.
Attachment #8908944 - Flags: review?(tcampbell) → review+
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2832e30d354
Restrict global sharing to desktop Firefox. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/a2832e30d354
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
This canceled the improvements noticed on Android in https://bugzilla.mozilla.org/show_bug.cgi?id=1381961#c16

== Change summary for alert #9501 (as of September 16 2017 04:29 UTC) ==

Regressions:

 39%  remote-blank summary android-4-4-armv7-api16 opt      816.48 -> 1,131.97
 24%  remote-blank summary android-7-1-armv8-api16 opt      506.68 -> 630.01
 22%  remote-blank summary android-4-2-armv7-api16 opt      1,257.64 -> 1,537.36
 18%  remote-twitter summary android-4-4-armv7-api16 opt    1,215.80 -> 1,435.96
 17%  remote-nytimes summary android-4-4-armv7-api16 opt    1,875.75 -> 2,201.11
 16%  remote-twitter summary android-7-1-armv8-api16 opt    809.18 -> 937.04
 13%  remote-nytimes summary android-7-1-armv8-api16 opt    1,169.54 -> 1,327.35

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9501
Will global sharing be re-enabled for Android? I want to file a dedicated tracking bug, to closely watch these improvements.
Flags: needinfo?(kmaglione+bmo)
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> Will global sharing be re-enabled for Android? I want to file a dedicated
> tracking bug, to closely watch these improvements.

I've filed bug 1400886 for enabling this on Android.
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.