Closed
Bug 140053
Opened 23 years ago
Closed 23 years ago
Missing trim() subroutine from checksetup.pl
Categories
(Bugzilla :: Installation & Upgrading, defect, P1)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ddkilzer, Assigned: zach)
Details
Attachments
(2 files)
|
650 bytes,
patch
|
Details | Diff | Splinter Review | |
|
527 bytes,
patch
|
Details | Diff | Splinter Review |
The patch for Bug 126571 removed the trim() subroutine from
checksetup.pl. However, the WriteOneDesc() subroutine uses
this during certain upgrade procedures. Either the one
instance where trim() is called should be replaced, or the
trim() subroutine should be reinstated.
|
Reporter | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
|
|
Reporter | |
Comment 1•23 years ago
|
||
Reverses the removal of the trim() subroutine.
|
|
Reporter | |
Comment 2•23 years ago
|
||
Replaces the call to the trim() subroutine with equivalent
code.
|
|
Reporter | |
Updated•23 years ago
|
|
||
Comment 3•23 years ago
|
||
trim was removed from checksetup.pl because it is defined in globals.pl, which
is required on line 537 of checksetup.pl. Is the function invokation actually
failing?
|
|
Reporter | |
Comment 4•23 years ago
|
||
Oops. Sorry about that. I didn't realize it was removed since
it was in globals.pl. Duh.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
|
||
Comment 5•23 years ago
|
||
clearing target milestone on invalid/duplicate/worksforme/wontfix bugs so
they'll show up as untriaged if they get reopened.
Target Milestone: Bugzilla 2.16 → ---
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•