1400624 - Crash in core::option::expect_failed | style::properties::{{impl}}::size_of

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[blinky]

Steps to reproduce:

1. Open https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%211479&authkey=ACzRuMhG5XptM9Q.
2. Open a new tab, then go to 'about:memory' then press 'Measure'.
3. Back to the tab.


Actual results:

The tab crashed.

Crash report: bp-4da057e0-bafd-4fea-b73e-c40ae0170916

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=68049206869794c62eeed0c56c72b30449ada6a7&tochange=485003aa6af0797f5e8a742acdb71f83cf134664

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1400624 - Fix a panic in Stylo memory reporting. .

`MallocSizeOfOps::enclosing_size_of_op` is an `Option<>` type, and the panic in
question is caused by not providing a value in a case where it's needed for
measuring a HashSet.

HashMaps and HashSets are common enough that it makes sense to make
`enclosing_size_of_op` non-optional, which this patch does.

Review commit: https://reviewboard.mozilla.org/r/180740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180740/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8909171 [details]
Bug 1400624 - Fix a panic in Stylo memory reporting. .

https://reviewboard.mozilla.org/r/180740/#review185816

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8909171 [details]
Bug 1400624 - Fix a panic in Stylo memory reporting. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180740/diff/1-2/

Comment 5

[Nicholas Nethercote [inactive]]

https://github.com/servo/servo/pull/18549 is the Servo PR.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cd29ce68eefe