1400665 - [Form Autofill] FormAutofillHandler.jsm, line 182: TypeError: fieldDetail is undefined

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P1)

Description

[Tim Taubert [:ttaubert] (inactive)]

I see it happen consistently with Nightly on https://demo.yubico.com/u2f

I first registered in the "Register" tab with test/test and some YubiKey. Then when I enter test/test on the "Login" tab the FormAutofillHandler fails somehow.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Looks like it's sufficient to directly click the "Login" tab, enter some username and then click to focus the password field.

Comment 2

[Ray Lin[:ralin]]

Hi Tim, it seems to me that form autofill should not be activated in this case as there are only two fields on the "Login" tab. Could you provide us a screenshot of the dropdown? so I can check whether the error occurred while previewing or in somewhere else. Thank you.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: FormFill error

Here you go.

Comment 4

[Ray Lin[:ralin]]

Thank you Tim, it's really helpful. I'll have a fix to this and go through the steps again with my Yubikey tomorrow.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Thanks! Just a note that you don't actually need your YubiKey though :) It triggers just fine in a profile that has some username suggestion from other websites.

Comment 6

[Ray Lin[:ralin]]

Attachment: Bug 1400665 - Add a explicit check for fieldDetail to avoid calling a method of "undefined".

Review commit: https://reviewboard.mozilla.org/r/181072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181072/

Comment 7

[Ray Lin[:ralin]]

(In reply to Tim Taubert [:ttaubert] from comment #5)
> Thanks! Just a note that you don't actually need your YubiKey though :) It
> triggers just fine in a profile that has some username suggestion from other
> websites.
Yeh, I just realized that occurs when every time popup closed, regardless of YubiKey. Thanks.
-----

The patch is simple, just added a check to ensure fieldDetail isn't null, and that seems like what we should have done originally to protect it from throwing potential undefined error. Luke, could you help me to review it? Thanks.

Comment 8

[Luke Chang [:lchang] (inactive)]

Sean happens to have a similar patch in bug 1400112. Let's see if we can leverage that part or wait for his patch if it's not in a hurry.

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8909598 [details]
Bug 1400665 - Add a explicit check for fieldDetail to avoid calling a method of "undefined".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181072/diff/1-2/

Comment 10

[Ray Lin[:ralin]]

(In reply to Luke Chang [:lchang] from comment #8)
> Sean happens to have a similar patch in bug 1400112. Let's see if we can
> leverage that part or wait for his patch if it's not in a hurry.

No problem, I've copied the part fixes the undefined problem. Your call anytime :D

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8909598 [details]
Bug 1400665 - Add a explicit check for fieldDetail to avoid calling a method of "undefined".

https://reviewboard.mozilla.org/r/181072/#review186954

Looks good. Thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2af29630cf
Add a explicit check for fieldDetail to avoid calling a method of "undefined". r=lchang

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9d2af29630cf