1400757 - Add MediaRecorder recording count, recording duration, and TrackEncoder init fail count telemetry

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, enhancement, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

As noted in Bug 1394943 it would be useful to gather MediaRecorder telemetry to guide development. I believe it would be useful to begin to gather the following:

- Recording count: a scalar probe of how many recordings where done per session
- Recording duration: a linear histogram probe of how long each recording was
- Init timeout count: a scalar probe of how many times the TrackEncoder init reached timeout (such as in Bug 1336367)

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

Add telemetry to collect the following:
- Number of times a MediaRecorder is started during a session
- Duration of media recordings
- How often we're timing out init of audio and video track encoders

Review commit: https://reviewboard.mozilla.org/r/180946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180946/

Comment 2

[François Marier [:francois]]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review186180

datareview+

::: toolkit/components/telemetry/Histograms.json:9246
(Diff revision 1)
> +  "MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE": {
> +    "record_in_processes": ["main", "content"],
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "60",
> +    "kind": "enumerated",
> +    "n_values": 8,

nit: Do you really need 8 here? Since you're only using 2 values, you could use 4 instead.

::: toolkit/components/telemetry/Histograms.json:9248
(Diff revision 1)
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "60",
> +    "kind": "enumerated",
> +    "n_values": 8,
> +    "bug_numbers": [1400757],
> +    "description": "Records the type of timeout that happened while attempting to init the encoder. Audio = 1, Video = 2. Recorded immediately following a timeout"

Also, any reason why you're not using the first value (`0`)?

i.e. 0=audio, 1=video

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180946/diff/1-2/

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review186180

> Also, any reason why you're not using the first value (`0`)?
> 
> i.e. 0=audio, 1=video

I was looking at one of the WebRTC items which is a bit field and I had mistakenly assumed we wered 1 indexed. Updated.

Comment 5

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review188684

I'm going to push this back until bug 1296531 has landed.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180946/diff/2-3/

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review189668

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03dca80f55ba
Add telemetry to MediaRecorder and TrackEncoder to track basic usage. r=francois,pehrsons

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/03dca80f55ba