Closed Bug 1400757 Opened 2 years ago Closed 2 years ago

Add MediaRecorder recording count, recording duration, and TrackEncoder init fail count telemetry

Categories

(Core :: Audio/Video: Recording, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As noted in Bug 1394943 it would be useful to gather MediaRecorder telemetry to guide development. I believe it would be useful to begin to gather the following:

- Recording count: a scalar probe of how many recordings where done per session
- Recording duration: a linear histogram probe of how long each recording was
- Init timeout count: a scalar probe of how many times the TrackEncoder init reached timeout (such as in Bug 1336367)
Assignee: nobody → bvandyk
Rank: 15
Priority: -- → P2
Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review186180

datareview+

::: toolkit/components/telemetry/Histograms.json:9246
(Diff revision 1)
> +  "MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE": {
> +    "record_in_processes": ["main", "content"],
> +    "alert_emails": ["bvandyk@mozilla.com"],
> +    "expires_in_version": "60",
> +    "kind": "enumerated",
> +    "n_values": 8,

nit: Do you really need 8 here? Since you're only using 2 values, you could use 4 instead.

::: toolkit/components/telemetry/Histograms.json:9248
(Diff revision 1)
> +    "alert_emails": ["bvandyk@mozilla.com"],
> +    "expires_in_version": "60",
> +    "kind": "enumerated",
> +    "n_values": 8,
> +    "bug_numbers": [1400757],
> +    "description": "Records the type of timeout that happened while attempting to init the encoder. Audio = 1, Video = 2. Recorded immediately following a timeout"

Also, any reason why you're not using the first value (`0`)?

i.e. 0=audio, 1=video
Attachment #8909452 - Flags: review?(francois) → review+
Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review186180

> Also, any reason why you're not using the first value (`0`)?
> 
> i.e. 0=audio, 1=video

I was looking at one of the WebRTC items which is a bit field and I had mistakenly assumed we wered 1 indexed. Updated.
Blocks: 1394943
Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review188684

I'm going to push this back until bug 1296531 has landed.
Attachment #8909452 - Flags: review?(apehrson)
Comment on attachment 8909452 [details]
Bug 1400757 - Add telemetry to MediaRecorder and TrackEncoder to track basic usage.

https://reviewboard.mozilla.org/r/180946/#review189668
Attachment #8909452 - Flags: review?(apehrson) → review+
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03dca80f55ba
Add telemetry to MediaRecorder and TrackEncoder to track basic usage. r=francois,pehrsons
https://hg.mozilla.org/mozilla-central/rev/03dca80f55ba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.