Closed Bug 1400762 Opened 2 years ago Closed 2 years ago

Deprecate dom.webcomponents.enabled and only use dom.webcomponents.customelements.enabled for Custom Elements

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jdai, Assigned: edgar)

References

Details

Attachments

(1 file)

After we deprecate custom element v0 code, we should also deprecate/turn off  'dom.webcomponents.enabled' preference[1].

[1] http://searchfox.org/mozilla-central/rev/2c9a5993ac40ec1db8450e3e0a85702fa291b9e2/testing/profiles/prefs_general.js#68
Summary: Turn off dom.webcomponents.enabled and use dom.webcomponents.customelements.enabled to instead → Deprecate dom.webcomponents.enabled and use dom.webcomponents.customelements.enabled to instead
We could use dom.customelements.enabled if we wanted to be less verbose :)
Priority: -- → P2
Hey John, not sure I got it - per your comment "deprecate/turn off  'dom.webcomponents.enabled'" then what's the difference b/w this bug and bug 1398981 comment 7? Are these two duplicates?
Flags: needinfo?(jdai)
It is because for bug 1398981, we still have custom element v0 code in our code base, we can turn off 'dom.webcomponents.enabled' preference in that bug. However, in this bug, we suppose land all of custom element v1 code in our code base, we should deprecate/remove 'dom.webcomponents.enabled' preference once for all.
Flags: needinfo?(jdai)
See Also: → 1397250
Blocks: 1397250
Summary: Deprecate dom.webcomponents.enabled and use dom.webcomponents.customelements.enabled to instead → Deprecate dom.webcomponents.enabled and only use dom.webcomponents.customelements.enabled for Custom Elements
In this bug, we are not going to remove dom.webcomponents.enabled pref, but just make it doesn't control CustomElements feature.
Assignee: nobody → echen
Attachment #8928469 - Flags: feedback?(jdai)
Comment on attachment 8928469 [details]
Bug 1400762 - Make dom.webcomponents.enabled pref doesn't control CustomElements feature;

Looks good to me.
Attachment #8928469 - Flags: feedback?(jdai) → feedback+
Attachment #8928469 - Flags: review?(bugs)
Comment on attachment 8928469 [details]
Bug 1400762 - Make dom.webcomponents.enabled pref doesn't control CustomElements feature;

https://reviewboard.mozilla.org/r/199722/#review205410
Attachment #8928469 - Flags: review?(bugs) → review+
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54321e8fe928
Make dom.webcomponents.enabled pref doesn't control CustomElements feature; r=smaug
https://hg.mozilla.org/mozilla-central/rev/54321e8fe928
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.