1400775 - Tracking Protection settings are not sorted the same way in Options

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Olivier Cuenot]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170917220255

Steps to reproduce:

Open the Options tab,
Click Privacy & Security,
Scroll to Tracking Protection.


Actual results:

"Use Tracking Protection to block known trackers" and "Send websites a “Do Not Track” signal that you don’t want to be tracked" options are not sorted the same way : "Always" is firstly the first, and then it is the last.
           


Expected results:

"Always" should be the first in both settings.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Tina / Cindy, should we make this change?

Comment 2

[Tina Hsieh[:Tina_Hsieh] UX]

The previous design was set the default option as the first item, but I see your point. It's inconsistent in Nightly when we have 3 radio button starting from "Always". Let's move the "Always" to the top :)

Thanks for the feedback!

Comment 3

[Ruslan Bekenev]

Attachment: Bug 1400775 - reorder tracking protection radio buttons for consistency;

Review commit: https://reviewboard.mozilla.org/r/259754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259754/

Comment 4

[Ruslan Bekenev]

hi everyone. 
It's my first attempt to submit a patch to Firefox so please let me know if I've made something wrong. 

I've just re-ordered radio buttons in "send websites do not track signal" section of about:preferences#privacy to make it look consistent with "block known trackers" section. 

Defaults values are not touched. 

flod was chosen as a reviewer based on hg log for the file I've changed. His nickname was using there mostly (at least at the beginning of the log).

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Ruslan Bekenev from comment #4)
> flod was chosen as a reviewer based on hg log for the file I've changed. His
> nickname was using there mostly (at least at the beginning of the log).

I have redirected to :jaws the review request, since this is just a code change and I'm not really a developer (I work on localization) ;-)

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995275 [details]
Bug 1400775 - reorder tracking protection radio buttons for consistency;

https://reviewboard.mozilla.org/r/259754/#review266734

Looks good! Thanks for your contribution. I'll queue this to get checked in now. If builds happen fast enough this change may appear in tomorrow's Nightly builds, if not the following day.

Comment 7

[Ruslan Bekenev]

wow, that's fast. thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525e36351899
reorder tracking protection radio buttons for consistency; r=jaws

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/525e36351899

Comment 10

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 57.0a1 (2017-09-18) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180730221422
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0