1400804 - (photon) First run tour - the Sync button is not visible, or squished, in landscape

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Oana Horvath [:ohorvath]]

Attachment: LG G4 (Android 6.0).png

[Tracking Requested - why for this release]:

Devices:
Huawei MediaPad M2 (Android 5.1.1)
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Prestigio Grace X5 (Android 4.4.2)
LG G4 (Android 6.0)

Build: Nightly 57.0a1 (2017-09-17);

Steps to reproduce:
1. With a clean profile, open Nightly.
2. Go to the Sync tab and turn the device in landscape mode.
3. Scroll down to see the sync button.

Expected result:
The buttons should be visible and should keep the same layout as in portrait.

Actual result:
On some devices, the button is not visible at all, cannot scroll lower than the "Start browsing" button.
On others, the button is visible, but the text & buttons are squished together.
See screenshots attached.

Comment 1

[Oana Horvath [:ohorvath]]

More screenshots: https://drive.google.com/drive/folders/0B0oX5SxK_oYENmVqbThEcm1iWHM?usp=sharing

Comment 2

[Wesly Huang (EPM)]

Nevin, would you help check it now since we are about to merge today.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1400804 - First run tour - the Sync button is not visible.

Review commit: https://reviewboard.mozilla.org/r/180840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180840/

Comment 4

[Jing-wei Wu [:jwu]]

Comment on attachment 8909247 [details]
Bug 1400804 -  First run tour - the Sync button is not visible.

https://reviewboard.mozilla.org/r/180840/#review185938

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 998c99d4c268 -d 8f132dd91e9c: rebasing 421210:998c99d4c268 "Bug 1400804 -  First run tour - the Sync button is not visible. r=jwu" (tip)
merging mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml
warning: conflicts while merging mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Carol Huang [:Carol]]

Hi Peko, 
please take a look at this onboarding layout.

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8909247 [details]
Bug 1400804 -  First run tour - the Sync button is not visible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180840/diff/1-2/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

APK here https://drive.google.com/file/d/0Bw-r8iYPh2ZDeW1LX0VxaFh0Qmc/view?usp=sharing
This needs to be landed before end of Sep 20

Comment 9

[Oana Horvath [:ohorvath]]

The apk looks good on my devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)
Motorola Nexus 6 (Android 7.0)
HTC 10 (Android 7.0.1)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865bfef2c528
First run tour - the Sync button is not visible. r=jwu

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/865bfef2c528

Comment 12

[Oana Horvath [:ohorvath]]

Verified as fixed in Nightly 57 (2017-09-21).
Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Motorola Nexus 6 (Android 7.0)
Samsung Galaxy Note 4 (Android 5.0.1)
Lenovo Yoga Tablet 2 (Android 4.4.2)
Prestigio Grace X5 (Android 4.4.2)