1400810 - Context menus look squashed/broken on Windows 7, especially when using the classic theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[:Gijs (he/him)]

Attachment: Screenshot

See screenshot.

Comment 1

[:Gijs (he/him)]

Looks like this was caused by removing the inline start padding from .menu-text on Windows.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1400810 - fix context menus looking squashed while retaining changes to shortcut and footer alignment,

Review commit: https://reviewboard.mozilla.org/r/180844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180844/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8909255 [details]
Bug 1400810 - fix context menus looking squashed while retaining changes to shortcut and footer alignment,

https://reviewboard.mozilla.org/r/180844/#review185990

The code looks good and I haven't been able to break it. As noted on IRC, I'm only experiencing this on Windows 7 classic mode, but the patch doesn't seem to negatively affect aero either.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dae5e4024d3
fix context menus looking squashed while retaining changes to shortcut and footer alignment, r=johannh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7dae5e4024d3

Comment 6

[Hani Yacoub, Desktop QA]

Build ID: 20170919220202
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 7 x64.