Closed Bug 1400863 Opened 2 years ago Closed 2 years ago
[Linux] Close button on the Tracking Protection tour popup is not scaled properly
14.96 KB, image/png
496.25 KB, image/png
59 bytes, text/x-review-board-request
The close (x) button is not scaled properly on the dialog that pops down to introduce users to Tracking Protection (see attached screenshot). I am using Firefox 57.0a1 20170917220255 on Fedora Linux 26 w/Gnome 3.24.2 on a Lenovo Thinkpad x260 with my screen at 1920x1080.
Johann, is this something that's trivial enough to do in 57 or should we put this on the backlog?
Looks like a regression from bug 1385702 to me, we'll take a look at it.
Component: Tracking Protection → Themes
Product: Firefox → Toolkit
Priority: -- → P3
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
I couldn't reproduce this on Windows 10. Based on comment #0 I assume this is Linux-only.
Summary: Close button on the Tracking Protection tour popup is not scaled properly → [Linux] Close button on the Tracking Protection tour popup is not scaled properly
Also broken in osx although doesnt look exactly the same
Assignee: nobody → dharvey
Status: NEW → ASSIGNED
Comment on attachment 8911119 [details] Bug 1400863 - Fix tracking protection close icon size. https://reviewboard.mozilla.org/r/182614/#review187870
Attachment #8911119 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ed02545eb650 Fix tracking protection close icon size. r=dao
Please request Beta approval on this when you get a chance.
Comment on attachment 8911119 [details] Bug 1400863 - Fix tracking protection close icon size. Approval Request Comment [Feature/Bug causing the regression]: photon-visual polish [User impact if declined]: Close buttons on tracking protection will be the wrong size [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: small css change [String changes made/needed]:
Attachment #8911119 - Flags: approval-mozilla-beta?
Comment on attachment 8911119 [details] Bug 1400863 - Fix tracking protection close icon size. Fix an ugly icon, taking it. Should be in 57b4 (gtb tomorrow Thursday)
Attachment #8911119 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I verified this on Mac OS X 10.10 and Ubuntu 16.04 with FF Nightly 58.0a1(2017-10-03) and FF beta 57.0b5 and I can confirm the fix.
You need to log in before you can comment on or make changes to this bug.