1400927 - Building Fennec on MacOS fails when trying to build u2fhid

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect, P1)

Description

[Dylan Roeh (:droeh) (he/him)]

Building Fennec on MacOS fails after the patches for bug 1388843:

> 0:25.19 error: native frameworks are only available on macOS targets
> 0:25.19 
> 0:25.35 error: aborting due to previous error
> 0:25.35 
> 0:25.38 error: Could not compile `u2fhid`.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Can you unbreak the build by emptying the main() function here?

https://searchfox.org/mozilla-central/source/dom/webauthn/u2f-hid-rs/build.rs#7

Comment 2

[Dylan Roeh (:droeh) (he/him)]

(In reply to Tim Taubert [:ttaubert] from comment #1)
> Can you unbreak the build by emptying the main() function here?
> 
> https://searchfox.org/mozilla-central/source/dom/webauthn/u2f-hid-rs/build.
> rs#7

Yeah, that unbreaks it.

Comment 3

[Ralph Giles (:rillian)]

Removing build.rs entirely is the easiest fix, but that does break `cargo test`.

You should just add #[link(name = "IOKit", kind = "framework")] to the `extern` blocks in src/macos/iokit.rs. That's where the symbols are imported and unlike `build.rs` it will only be compiled if the eventual target is macOS.

Comment 4

[Ralph Giles (:rillian)]

Attachment: Fix Android build

Suggested patch per my comment above.

I didn't try a full fennec build, but with this change the following crate-local tests worked:

cargo build
cargo test
cargo build --target armv7-linux-androideabi

Where the latter previously reproduced the `native frameworks` failure from the description.

Comment 5

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8909551 [details] [diff] [review]
Fix Android build

Review of attachment 8909551 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, and it works for me, too, building from OSX both Fennec and OSX Desktop. 

I've pushed it into https://github.com/jcjones/u2f-hid-rs/pull/46 as well.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa403d810d8
Fix u2f-hid-rs cross-compilation on macOS r=jcj

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3aa403d810d8